linux-kernel - Re: [PATCH] scsi: bfa: Replace kzalloc + copy_from_user with memdup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <F0B8FDF9-027D-4CCD-A5CA-91E7B2FF4950@linux.dev>
Date: Thu, 25 Sep 2025 20:13:09 +0200
From: Thorsten Blum <thorsten.blum@...ux.dev>
To: "Martin K. Petersen" <martin.petersen@...cle.com>
Cc: Anil Gurumurthy <anil.gurumurthy@...gic.com>,
 Sudarsana Kalluru <sudarsana.kalluru@...gic.com>,
 "James E.J. Bottomley" <James.Bottomley@...senPartnership.com>,
 linux-scsi@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] scsi: bfa: Replace kzalloc + copy_from_user with
 memdup_user

Hi Martin,

On 25. Sep 2025, at 04:10, Martin K. Petersen wrote:
> 
>> No functional changes intended other than returning the more idiomatic
>> error code -EFAULT.
> 
> How can we be sure that this doesn't break existing applications?

I guess we can't because the error code is returned to userspace as the
result of a bsg_job? That wasn't immediately obvious to me.

Thanks,
Thorsten