linux-kernel - Re: [PATCH] scsi: bfa: Replace kzalloc + copy_from_user with memdup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <yq1jz1hnggp.fsf@ca-mkp.ca.oracle.com>
Date: Mon, 29 Sep 2025 16:49:02 -0400
From: "Martin K. Petersen" <martin.petersen@...cle.com>
To: Thorsten Blum <thorsten.blum@...ux.dev>
Cc: "Martin K. Petersen" <martin.petersen@...cle.com>,
        Anil Gurumurthy
 <anil.gurumurthy@...gic.com>,
        Sudarsana Kalluru
 <sudarsana.kalluru@...gic.com>,
        "James E.J. Bottomley"
 <James.Bottomley@...senPartnership.com>,
        linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] scsi: bfa: Replace kzalloc + copy_from_user with
 memdup_user


Hi Thorsten!

>>> No functional changes intended other than returning the more
>>> idiomatic error code -EFAULT.
>> 
>> How can we be sure that this doesn't break existing applications?
>
> I guess we can't because the error code is returned to userspace as
> the result of a bsg_job? That wasn't immediately obvious to me.

Correct. And with little chance of having the associated management
utilities updated, it's best to leave things as they are.

-- 
Martin K. Petersen