linux-kernel - Re: [PATCH] crypto: padlock-sha - Add support for Zhaoxin processor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aNWkwiHk7sFkHEVp@eldamar.lan>
Date: Thu, 25 Sep 2025 22:23:30 +0200
From: Salvatore Bonaccorso <carnil@...ian.org>
To: AlanSong-oc <AlanSong-oc@...oxin.com>
Cc: Herbert Xu <herbert@...dor.apana.org.au>, davem@...emloft.net,
	linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org,
	CobeChen@...oxin.com, TonyWWang-oc@...oxin.com, YunShen@...oxin.com,
	GeorgeXue@...oxin.com, LeoLiu-oc@...oxin.com, HansHu@...oxin.com,
	Larry Wei <larryw3i@...h.net>, 1113996@...s.debian.org
Subject: Re: [PATCH] crypto: padlock-sha - Add support for Zhaoxin processor

Hi,

On Wed, Jun 25, 2025 at 09:51:56AM +0800, AlanSong-oc wrote:
> On 6/23/2025 5:24 PM, Herbert Xu wrote:
> > Thanks for the explanation.  There is no requirement to use struct
> > sha1_state.  Just supply a custom version of the struct for the
> > shash descriptor that includes the necessary space.
> > 
> > IOW do the copy in the rarely used export/import functions, instead
> > of on every hash operation.
> 
> Sorry for the late reply. Thank you for your suggestion and review.
> 
> I will send an updated patch soon.

FWIW, Larry Wei reported this issue as well in a separate Debian bug
report at https://bugs.debian.org/1113996 .

So far there was no patch applied to mainline if I'm correct. Did that
felt through the cracks?

Regards,
Salvatore