linux-kernel - Re: [PATCH v7 04/12] i2c: rtl9300: use regmap fields and API for registers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <476cd546-1bde-4ff0-a785-2e6fa21b79d4@gmail.com>
Date: Thu, 25 Sep 2025 23:46:08 +0200
From: Jonas Jelonek <jelonek.jonas@...il.com>
To: Wolfram Sang <wsa+renesas@...g-engineering.com>
Cc: Chris Packham <chris.packham@...iedtelesis.co.nz>,
 Andi Shyti <andi.shyti@...nel.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, linux-i2c@...r.kernel.org,
 Conor Dooley <conor+dt@...nel.org>, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, Markus Stockhausen
 <markus.stockhausen@....de>, Sven Eckelmann <sven@...fation.org>,
 Harshal Gohel <hg@...onwunderlich.de>
Subject: Re: [PATCH v7 04/12] i2c: rtl9300: use regmap fields and API for
 registers


On 25.09.25 23:30, Wolfram Sang wrote:
> On Sun, Aug 31, 2025 at 10:04:49AM +0000, Jonas Jelonek wrote:
>> Adapt the RTL9300 I2C controller driver to use more of the regmap
>> API, especially make use of reg_field and regmap_field instead of macros
>> to represent registers. Most register operations are performed through
>> regmap_field_* API then.
>>
>> Handle SCL selection using separate chip-specific functions since this
>> is already known to differ between the Realtek SoC families in such a
>> way that this cannot be properly handled using just a different
>> reg_field.
>>
>> This makes it easier to add support for newer generations or to handle
>> differences between specific revisions within a series. Just by
>> defining a separate driver data structure with the corresponding
>> register field definitions and linking it to a new compatible.
>>
>> Signed-off-by: Jonas Jelonek <jelonek.jonas@...il.com>
>> Tested-by: Sven Eckelmann <sven@...fation.org>
>> Reviewed-by: Chris Packham <chris.packham@...iedtelesis.co.nz>
>> Tested-by: Chris Packham <chris.packham@...iedtelesis.co.nz> # On RTL9302C based board
>> Tested-by: Markus Stockhausen <markus.stockhausen@....de>
> I wanted to apply the rest of this series but applying fails. Can you
> kindly rebase it to 6.17-rc5 or later?
>

I just noticed that it seems like an already applied patch got lost [1].
This was supposed to be merged to Andi's i2c/i2c-host [2] and actually was
there until the first three patches of this series got merged.

Since I had already issue a few days ago trying to rebase the remaining
patches, this might be the cause it also fails for you?

Best,
Jonas Jelonek

[1] https://lore.kernel.org/linux-i2c/20250810-i2c-rtl9300-multi-byte-v5-5-cd9dca0db722@narfation.org/
[2] https://lore.kernel.org/linux-i2c/a422shurtl3xrvnh2ieynqq2kw5awqnmall2wjdpozx336m26i@54ekftmkwvrv/