linux-kernel - Re: [PATCH 1/5] ASoC: codecs: va-macro: Rework version checking

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <202509261315.O9CiiXjb-lkp@intel.com>
Date: Fri, 26 Sep 2025 13:36:24 +0800
From: kernel test robot <lkp@...el.com>
To: Jingyi Wang <jingyi.wang@....qualcomm.com>,
	Srinivas Kandagatla <srini@...nel.org>,
	Liam Girdwood <lgirdwood@...il.com>,
	Mark Brown <broonie@...nel.org>, Jaroslav Kysela <perex@...ex.cz>,
	Takashi Iwai <tiwai@...e.com>, Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Rao Mandadapu <quic_srivasam@...cinc.com>
Cc: llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev,
	aiqun.yu@....qualcomm.com, tingwei.zhang@....qualcomm.com,
	trilok.soni@....qualcomm.com, yijie.yang@....qualcomm.com,
	linux-sound@...r.kernel.org, linux-arm-msm@...r.kernel.org,
	linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
	Jingyi Wang <jingyi.wang@....qualcomm.com>,
	Konrad Dybcio <konrad.dybcio@....qualcomm.com>,
	Prasad Kumpatla <prasad.kumpatla@....qualcomm.com>
Subject: Re: [PATCH 1/5] ASoC: codecs: va-macro: Rework version checking

Hi Jingyi,

kernel test robot noticed the following build errors:

[auto build test ERROR on ae2d20002576d2893ecaff25db3d7ef9190ac0b6]

url:    https://github.com/intel-lab-lkp/linux/commits/Jingyi-Wang/ASoC-codecs-va-macro-Rework-version-checking/20250925-080338
base:   ae2d20002576d2893ecaff25db3d7ef9190ac0b6
patch link:    https://lore.kernel.org/r/20250924-knp-audio-v1-1-5afa926b567c%40oss.qualcomm.com
patch subject: [PATCH 1/5] ASoC: codecs: va-macro: Rework version checking
config: i386-buildonly-randconfig-001-20250926 (https://download.01.org/0day-ci/archive/20250926/202509261315.O9CiiXjb-lkp@intel.com/config)
compiler: clang version 20.1.8 (https://github.com/llvm/llvm-project 87f0227cb60147a26a1eeb4fb06e3b505e9c7261)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250926/202509261315.O9CiiXjb-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202509261315.O9CiiXjb-lkp@intel.com/

All errors (new ones prefixed by >>):

>> sound/soc/codecs/lpass-va-macro.c:1479:8: error: call to undeclared function 'FIELD_GET'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
    1479 |         maj = FIELD_GET(CORE_ID_0_REV_MAJ, val);
         |               ^
   1 error generated.


vim +/FIELD_GET +1479 sound/soc/codecs/lpass-va-macro.c

  1471	
  1472	static int va_macro_set_lpass_codec_version(struct va_macro *va)
  1473	{
  1474		int version = LPASS_CODEC_VERSION_UNKNOWN;
  1475		u32 maj, min, step;
  1476		u32 val;
  1477	
  1478		regmap_read(va->regmap, CDC_VA_TOP_CSR_CORE_ID_0, &val);
> 1479		maj = FIELD_GET(CORE_ID_0_REV_MAJ, val);
  1480	
  1481		regmap_read(va->regmap, CDC_VA_TOP_CSR_CORE_ID_1, &val);
  1482		if (!FIELD_GET(CORE_ID_1_HAS_VAMACRO, val)) {
  1483			dev_err(va->dev, "This is not a VA macro instance\n");
  1484			return -ENODEV;
  1485		}
  1486	
  1487		regmap_read(va->regmap, CDC_VA_TOP_CSR_CORE_ID_2, &val);
  1488		min = FIELD_GET(CORE_ID_2_REV_MIN, val);
  1489		step = FIELD_GET(CORE_ID_2_REV_STEP, val);
  1490	
  1491		if (maj == 1) {
  1492			version = LPASS_CODEC_VERSION_2_0;
  1493		} else if (maj == 2) {
  1494			switch (min) {
  1495			case 0:
  1496				version = LPASS_CODEC_VERSION_2_0;
  1497				break;
  1498			case 5:
  1499				version = LPASS_CODEC_VERSION_2_5;
  1500				break;
  1501			case 6:
  1502				version = LPASS_CODEC_VERSION_2_6;
  1503				break;
  1504			case 7:
  1505				version = LPASS_CODEC_VERSION_2_7;
  1506				break;
  1507			case 8:
  1508				version = LPASS_CODEC_VERSION_2_8;
  1509				break;
  1510			case 9:
  1511				version = LPASS_CODEC_VERSION_2_9;
  1512				break;
  1513			default:
  1514				break;
  1515			}
  1516		}
  1517	
  1518		if (version == LPASS_CODEC_VERSION_UNKNOWN) {
  1519			dev_err(va->dev, "VA Macro v%u.%u.%u is not supported\n",
  1520				maj, min, step);
  1521			return -EOPNOTSUPP;
  1522		}
  1523	
  1524		lpass_macro_set_codec_version(version);
  1525	
  1526		dev_dbg(va->dev, "LPASS Codec Version %s\n", lpass_macro_get_codec_version_string(version));
  1527	
  1528		return 0;
  1529	}
  1530	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki