linux-kernel - Re: [PATCH] gfs2: Move i_nlink checks from gfs2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ae2db4c3-3769-4945-97bc-2407a260886b@linux.dev>
Date: Fri, 26 Sep 2025 13:37:34 +0800
From: Youling Tang <youling.tang@...ux.dev>
To: Al Viro <viro@...iv.linux.org.uk>
Cc: Andreas Gruenbacher <agruenba@...hat.com>, gfs2@...ts.linux.dev,
 linux-kernel@...r.kernel.org, Youling Tang <tangyouling@...inos.cn>
Subject: Re: [PATCH] gfs2: Move i_nlink checks from gfs2_{link,rename,mkdir}
 to VFS layer

On 9/26/25 12:48, Al Viro wrote:

> On Fri, Sep 26, 2025 at 10:56:04AM +0800, Youling Tang wrote:
>> From: Youling Tang <tangyouling@...inos.cn>
>>
>> vfs_{link, rename, mkdir} will check i_nlink. When sb->s_max_links is set,
>> set sb->s_max_links in gfs2 to simplify the code.
> For gfs2 you are going to run into a problem - link count is not stable until
> you take gfs2 locks; checks in vfs_link() et.al. will be inevitably racy for
> cluster filesystems.

Thank you for pointing out this important issue. Let's discard this patch.

Thanks,
Youling.