linux-kernel - RE: [PATCH] sched/fair: Correct misleading comment in task_numa

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8c88ffd5e9de4a4cb56068c506e0cdbf@hygon.cn>
Date: Fri, 26 Sep 2025 11:59:58 +0000
From: Jianyong Wu <wujianyong@...on.cn>
To: "mingo@...hat.com" <mingo@...hat.com>, "peterz@...radead.org"
	<peterz@...radead.org>, "juri.lelli@...hat.com" <juri.lelli@...hat.com>,
	"vincent.guittot@...aro.org" <vincent.guittot@...aro.org>, Rik van Riel
	<riel@...riel.com>
CC: "dietmar.eggemann@....com" <dietmar.eggemann@....com>,
	"rostedt@...dmis.org" <rostedt@...dmis.org>, "bsegall@...gle.com"
	<bsegall@...gle.com>, "mgorman@...e.de" <mgorman@...e.de>,
	"vschneid@...hat.com" <vschneid@...hat.com>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "jianyong.wu@...look.com"
	<jianyong.wu@...look.com>
Subject: RE: [PATCH] sched/fair: Correct misleading comment in
 task_numa_migrate()

Hi Peter, Rik, and maintainers,

Gentle ping on this small comment fix patch.

It was reviewed by Rik about 3 weeks ago and got a " Reviewed-by" [1]. Since then there has been no further comments. I just wonder if there are any other concerns or if it is ready to be picked up.

The original patch is here:

[1] https://lore.kernel.org/lkml/20250908061923.543081-1-wujianyong@hygon.cn/

Thanks for your time.

Best regards,
Jianyong Wu

Jianyong Wu> -----Original Message-----
> From: Rik van Riel <riel@...riel.com>
> Sent: Tuesday, September 9, 2025 12:26 AM
> To: Jianyong Wu <wujianyong@...on.cn>; mingo@...hat.com;
> peterz@...radead.org; juri.lelli@...hat.com; vincent.guittot@...aro.org;
> jianyong.wu@...look.com
> Cc: dietmar.eggemann@....com; rostedt@...dmis.org; bsegall@...gle.com;
> mgorman@...e.de; vschneid@...hat.com; linux-kernel@...r.kernel.org
> Subject: Re: [PATCH] sched/fair: Correct misleading comment in
> task_numa_migrate()
> 
> On Mon, 2025-09-08 at 14:19 +0800, Jianyong Wu wrote:
> > The current comment implies that both the task and the group must get
> > benefit for a node to be considered. However, the actual code allows a
> > node to pass if *either* the task *or* the group meets the criteria.
> >
> > As established in the previous discussion [1], the code logic is
> > correct.
> > Update the comment to accurately reflect that either condition is
> > sufficient.
> >
> > Signed-off-by: Jianyong Wu <wujianyong@...on.cn>
> 
> Reviewed-by: Rik van Riel <riel@...riel.com>
> 
> --
> All Rights Reversed.