linux-kernel - Re: [PATCH v4 1/6] vduse: make domain

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3e5abb75-2192-46dc-a44e-d66fed87fc63@leemhuis.info>
Date: Sat, 27 Sep 2025 08:27:22 +0200
From: Thorsten Leemhuis <linux@...mhuis.info>
To: Eugenio Pérez <eperezma@...hat.com>,
 "Michael S . Tsirkin" <mst@...hat.com>
Cc: Yongji Xie <xieyongji@...edance.com>, Cindy Lu <lulu@...hat.com>,
 jasowang@...hat.com, linux-kernel@...r.kernel.org,
 Maxime Coquelin <mcoqueli@...hat.com>, Xuan Zhuo
 <xuanzhuo@...ux.alibaba.com>, Laurent Vivier <lvivier@...hat.com>,
 virtualization@...ts.linux.dev, Stefano Garzarella <sgarzare@...hat.com>,
 Linux kernel regressions list <regressions@...ts.linux.dev>,
 Linux Next Mailing List <linux-next@...r.kernel.org>
Subject: Re: [PATCH v4 1/6] vduse: make domain_lock an rwlock

On 25.09.25 11:13, Eugenio Pérez wrote:
> It will be used in a few more scenarios read-only so make it more
> scalable.
> [...]
> diff --git a/drivers/vdpa/vdpa_user/vduse_dev.c b/drivers/vdpa/vdpa_user/vduse_dev.c
> index e7bced0b5542..2b6a8958ffe0 100644
> --- a/drivers/vdpa/vdpa_user/vduse_dev.c
> +++ b/drivers/vdpa/vdpa_user/vduse_dev.c
> @@ -14,6 +14,7 @@
>  #include <linux/cdev.h>
>  #include <linux/device.h>
>  #include <linux/eventfd.h>
> +#include <linux/rwlock.h>

Lo! My daily -next builds based for Fedora using the Fedora rawhide
failed yesterday on various archs. I suspect it's due to above change,
as this was the error I got:

"""
In file included from drivers/vdpa/vdpa_user/vduse_dev.c:17:
./include/linux/rwlock.h:5:3: error: #error "Please do not include this
file directly."
    5 | # error "Please do not include this file directly."
      |   ^~~~~
./include/linux/rwlock.h:27:10: warning: ‘rwlock_init’ redefined
   27 | # define rwlock_init(lock)                                      \
      |          ^~~~~~~~~~~
In file included from ./include/linux/spinlock_rt.h:153,
                 from ./include/linux/spinlock.h:455,
                 from ./include/linux/sched.h:37,
                 from ./include/linux/percpu.h:12,
                 from ./arch/x86/include/asm/msr.h:16,
                 from ./arch/x86/include/asm/tsc.h:11,
                 from ./arch/x86/include/asm/timex.h:6,
                 from ./include/linux/timex.h:67,
                 from ./include/linux/time32.h:13,
                 from ./include/linux/time.h:60,
                 from ./include/linux/jiffies.h:10,
                 from ./include/linux/ktime.h:25,
                 from ./include/linux/timer.h:6,
                 from ./include/linux/netdevice.h:24,
                 from ./include/linux/if_vlan.h:10,
                 from ./include/linux/virtio_net.h:5,
                 from drivers/vdpa/vdpa_user/vduse_dev.c:11:
"""

For a complete log, see
https://download.copr.fedorainfracloud.org/results/@kernel-vanilla/next/fedora-rawhide-x86_64/09603789-next-next-all/builder-live.log.gz

Reverting the series made things work for me.

> [...]

Ciao, Thorsten