linux-kernel - Re: [PATCH v4 5/6] vduse: add vq group asid support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACGkMEu6BcPfzuPFJ8REO6WGKmH+8n6S7c0Gjjzi+CP-q5kHQQ@mail.gmail.com>
Date: Fri, 26 Sep 2025 16:37:40 +0800
From: Jason Wang <jasowang@...hat.com>
To: Eugenio Perez Martin <eperezma@...hat.com>
Cc: "Michael S . Tsirkin" <mst@...hat.com>, Yongji Xie <xieyongji@...edance.com>, Cindy Lu <lulu@...hat.com>, 
	linux-kernel@...r.kernel.org, Maxime Coquelin <mcoqueli@...hat.com>, 
	Xuan Zhuo <xuanzhuo@...ux.alibaba.com>, Laurent Vivier <lvivier@...hat.com>, 
	virtualization@...ts.linux.dev, Stefano Garzarella <sgarzare@...hat.com>
Subject: Re: [PATCH v4 5/6] vduse: add vq group asid support

On Fri, Sep 26, 2025 at 4:17 PM Eugenio Perez Martin
<eperezma@...hat.com> wrote:
>
> On Fri, Sep 26, 2025 at 9:58 AM Jason Wang <jasowang@...hat.com> wrote:
> >
> > On Thu, Sep 25, 2025 at 5:14 PM Eugenio Pérez <eperezma@...hat.com> wrote:
> > >
> > > Add support for assigning Address Space Identifiers (ASIDs) to each VQ
> > > group.  This enables mapping each group into a distinct memory space.
> > >
> > > Now that the driver can change ASID in the middle of operation, the
> > > domain that each vq address point is also protected by domain_lock.
> > >
> > > Signed-off-by: Eugenio Pérez <eperezma@...hat.com>
> > > ---
> > > v4:

[...]

> > >   * Structure used by read(2) on /dev/vduse/$NAME.
> > > @@ -334,6 +376,9 @@ struct vduse_dev_request {
> > >                 struct vduse_vq_state vq_state;
> > >                 struct vduse_dev_status s;
> > >                 struct vduse_iova_range iova;
> > > +               /* Following members only if vduse api version >= 1 */;
> >
> > This comment is confusing since padding exists before.
> >
>
> Ok that's totally right. Should it say "following members but padding"?

That's fine.

Thanks