linux-kernel - Re: [PATCH] ntfs3: fix uninit memory after failed mi_read in mi_format

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <56d8cad5-d8ab-436d-bad0-c631e414c70d@gmail.com>
Date: Sun, 28 Sep 2025 11:17:26 -0400
From: David Hunter <david.hunter.linux@...il.com>
To: Raphael Pinsonneault-Thibeault <rpthibeault@...il.com>,
 almaz.alexandrovich@...agon-software.com
Cc: ntfs3@...ts.linux.dev, linux-kernel@...r.kernel.org,
 skhan@...uxfoundation.org,
 syzbot+7a2ba6b7b66340cff225@...kaller.appspotmail.com
Subject: Re: [PATCH] ntfs3: fix uninit memory after failed mi_read in
 mi_format_new

On 9/25/25 16:36, Raphael Pinsonneault-Thibeault wrote:
> attr_insert_range() called from ntfs_fallocate() has 2 different
> code paths that trigger mi_read() (which calls ntfs_read_bh).
> If the first mi_read() -> ntfs_read_bh() fails with an IO error, it
> leaves an uninitialized buffer in the buffer cache.
> The second mi_read() -> ntfs_read_bh() then uses that buffer,
> where we get KMSAN warning "uninit-value in ntfs_read_bh".
> 
> The fix is to check if mi_read failed in mi_format_new.
> 


Did you do any testing for this patch?

David Hunter