linux-kernel - Re: [PATCH] ntfs3: fix uninit memory after failed mi_read in mi_format

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c5194ece-e402-49ba-8b15-674c782b1a6c@gmail.com>
Date: Sun, 28 Sep 2025 11:25:14 -0400
From: David Hunter <david.hunter.linux@...il.com>
To: Raphael Pinsonneault-Thibeault <rpthibeault@...il.com>,
 almaz.alexandrovich@...agon-software.com
Cc: ntfs3@...ts.linux.dev, linux-kernel@...r.kernel.org,
 skhan@...uxfoundation.org,
 syzbot+7a2ba6b7b66340cff225@...kaller.appspotmail.com
Subject: Re: [PATCH] ntfs3: fix uninit memory after failed mi_read in
 mi_format_new

On 9/25/25 16:36, Raphael Pinsonneault-Thibeault wrote:

> -	} else if (mi_read(mi, is_mft)) {
> -		;
> -	} else if (rec->rhdr.sign == NTFS_FILE_SIGNATURE) {
> -		/* Record is reused. Update its sequence number. */
> -		seq = le16_to_cpu(rec->seq) + 1;
> -		if (!seq)
> -			seq = 1;
> +	} else {
> +		err = mi_read(mi, is_mft);
> +		if (err) {
> +			return err;
> +		}
> +
> +		if (rec->rhdr.sign == NTFS_FILE_SIGNATURE) {
> +			/* Record is reused. Update its sequence number. */
> +			seq = le16_to_cpu(rec->seq) + 1;
> +			if (!seq)
> +				seq = 1;
> +		}

How was this tested?