linux-kernel - Re: [PATCH v3 03/16] x86/virt/tdx: Simplify tdmr_get_pamt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <090314f1cf49e029b77730f7ead8b028a7acc524.camel@intel.com>
Date: Mon, 29 Sep 2025 17:47:44 +0000
From: "Edgecombe, Rick P" <rick.p.edgecombe@...el.com>
To: "kvm@...r.kernel.org" <kvm@...r.kernel.org>, "linux-coco@...ts.linux.dev"
	<linux-coco@...ts.linux.dev>, "Huang, Kai" <kai.huang@...el.com>, "Li,
 Xiaoyao" <xiaoyao.li@...el.com>, "Zhao, Yan Y" <yan.y.zhao@...el.com>,
	"dave.hansen@...ux.intel.com" <dave.hansen@...ux.intel.com>, "kas@...nel.org"
	<kas@...nel.org>, "seanjc@...gle.com" <seanjc@...gle.com>, "mingo@...hat.com"
	<mingo@...hat.com>, "pbonzini@...hat.com" <pbonzini@...hat.com>,
	"tglx@...utronix.de" <tglx@...utronix.de>, "Yamahata, Isaku"
	<isaku.yamahata@...el.com>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "Annapurve, Vishal" <vannapurve@...gle.com>,
	"bp@...en8.de" <bp@...en8.de>, "Gao, Chao" <chao.gao@...el.com>,
	"x86@...nel.org" <x86@...nel.org>
Subject: Re: [PATCH v3 03/16] x86/virt/tdx: Simplify tdmr_get_pamt_sz()

On Mon, 2025-09-29 at 19:44 +0800, Xiaoyao Li wrote:
> On 9/19/2025 8:50 AM, Huang, Kai wrote:
> > >    static unsigned long tdmr_get_pamt_sz(struct tdmr_info *tdmr, int pgsz,
> > > -				      u16 pamt_entry_size)
> > > +				      u16 pamt_entry_size[])
> > AFAICT you don't need pass the whole 'pamt_entry_size[]' array, passing
> > the correct pamt_entry_size should be enough.
> 
> While we are at it, how about just moving the definition of 
> pamt_entry_size[] from construct_tdmrs() to here?

Oh yea, that is better.