[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20250929-challenge-molecular-947bb1f5962b@spud>
Date: Mon, 29 Sep 2025 18:48:22 +0100
From: Conor Dooley <conor@...nel.org>
To: Yixun Lan <dlan@...too.org>
Cc: Troy Mitchell <troy.mitchell@...ux.dev>, Rob Herring <robh@...nel.org>,
Krzysztof Kozlowski <krzk+dt@...nel.org>,
Conor Dooley <conor+dt@...nel.org>,
Paul Walmsley <paul.walmsley@...ive.com>,
Palmer Dabbelt <palmer@...belt.com>,
Albert Ou <aou@...s.berkeley.edu>, Alexandre Ghiti <alex@...ti.fr>,
Yangyu Chen <cyy@...self.name>,
Troy Mitchell <troy.mitchell@...ux.spacemit.com>,
devicetree@...r.kernel.org, linux-riscv@...ts.infradead.org,
spacemit@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: riscv: spacemit: Add MusePi Pro board
On Sun, Sep 28, 2025 at 03:49:14PM +0800, Yixun Lan wrote:
> Hi Troy,
>
> On 12:16 Sun 28 Sep , Troy Mitchell wrote:
> > From: Troy Mitchell <troy.mitchell@...ux.spacemit.com>
> >
> > Document the compatible string for the MusePi Pro [1].
> > It is a 1.8-inch single board computer based on the
> > SpacemiT K1/M1 RISC-V SoC [2].
> you could wrap at slightly more characters, I remember 72 chars
> (haven't spent time to find a formal document link..)
>
> >
> > Link:
> > https://developer.spacemit.com/documentation?token=YJtdwnvvViPVcmkoPDpcvwfVnrh&type=pdf
> I'd suggest to list core features of this board, while using this link as a complement,
> base on previous experience, vendor may change the link address, thus the link vanish
The link doesn't even work for me. Is this board actually made by
spacemit as a developer platform?
>
> > [1]
> > https://www.spacemit.com/en/key-stone-k1 [2]
> >
> pleae keep them in one line, no break, and no blank line between SoB,
> something as below
> Link: https://.. [1]
>
> > Signed-off-by: Troy Mitchell <troy.mitchell@...ux.spacemit.com>
> > ---
> > Documentation/devicetree/bindings/riscv/spacemit.yaml | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/Documentation/devicetree/bindings/riscv/spacemit.yaml b/Documentation/devicetree/bindings/riscv/spacemit.yaml
> > index c56b62a6299ac24d3cdef7edcdfc407dc62a1846..52fe39296031f21d1c28c4f1ea5ca9fe28caf45a 100644
> > --- a/Documentation/devicetree/bindings/riscv/spacemit.yaml
> > +++ b/Documentation/devicetree/bindings/riscv/spacemit.yaml
> > @@ -22,6 +22,7 @@ properties:
> > - enum:
> > - bananapi,bpi-f3
> > - milkv,jupiter
> > + - spacemit,musepi-pro
> > - xunlong,orangepi-rv2
> > - const: spacemit,k1
> >
> >
> > --
> > 2.51.0
> >
>
> --
> Yixun Lan (dlan)
Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)
Powered by blists - more mailing lists