linux-kernel - Re: [PATCH V3 2/2] tty: serial: imx: Add missing wakeup event reporting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <bc4beaa6-8391-4ba8-b6c4-bde1c00d0375@kernel.org>
Date: Mon, 29 Sep 2025 07:58:05 +0200
From: Jiri Slaby <jirislaby@...nel.org>
To: Frank Li <Frank.li@....com>, Sherry Sun <sherry.sun@....com>
Cc: gregkh@...uxfoundation.org, shawnguo@...nel.org, s.hauer@...gutronix.de,
 kernel@...gutronix.de, festevam@...il.com, shenwei.wang@....com,
 peng.fan@....com, linux-serial@...r.kernel.org,
 linux-kernel@...r.kernel.org, imx@...ts.linux.dev
Subject: Re: [PATCH V3 2/2] tty: serial: imx: Add missing wakeup event
 reporting

On 25. 09. 25, 17:49, Frank Li wrote:
>> @@ -2732,10 +2734,14 @@ static void imx_uart_enable_wakeup(struct imx_port *sport, bool on)
>>   			ucr1 |= UCR1_RTSDEN;
>>   		} else {
>>   			ucr1 &= ~UCR1_RTSDEN;
>> +			wake_active |= !!(usr1 & USR1_RTSD);
> 
> I think you miss understand my means. suppose bool type only support
> ||, &&, ==, !=, !
> 
> 	wake_active = wake_active || (usr1 & USR1_RTSD);

+1 to this. Much easier to understand (for me at least).

thanks,
-- 
js
suse labs