linux-kernel - RE: [PATCH V3 2/2] tty: serial: imx: Add missing wakeup event reporting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <DB9PR04MB8429ABE490A4669349FA217592E7A@DB9PR04MB8429.eurprd04.prod.outlook.com>
Date: Thu, 2 Oct 2025 03:44:37 +0000
From: Sherry Sun <sherry.sun@....com>
To: Jiri Slaby <jirislaby@...nel.org>, Frank Li <frank.li@....com>
CC: "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
	"shawnguo@...nel.org" <shawnguo@...nel.org>, "s.hauer@...gutronix.de"
	<s.hauer@...gutronix.de>, "kernel@...gutronix.de" <kernel@...gutronix.de>,
	"festevam@...il.com" <festevam@...il.com>, Shenwei Wang
	<shenwei.wang@....com>, Peng Fan <peng.fan@....com>,
	"linux-serial@...r.kernel.org" <linux-serial@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"imx@...ts.linux.dev" <imx@...ts.linux.dev>
Subject: RE: [PATCH V3 2/2] tty: serial: imx: Add missing wakeup event
 reporting



> -----Original Message-----
> From: Jiri Slaby <jirislaby@...nel.org>
> Sent: Monday, September 29, 2025 1:58 PM
> To: Frank Li <frank.li@....com>; Sherry Sun <sherry.sun@....com>
> Cc: gregkh@...uxfoundation.org; shawnguo@...nel.org;
> s.hauer@...gutronix.de; kernel@...gutronix.de; festevam@...il.com;
> Shenwei Wang <shenwei.wang@....com>; Peng Fan <peng.fan@....com>;
> linux-serial@...r.kernel.org; linux-kernel@...r.kernel.org;
> imx@...ts.linux.dev
> Subject: Re: [PATCH V3 2/2] tty: serial: imx: Add missing wakeup event
> reporting
> 
> On 25. 09. 25, 17:49, Frank Li wrote:
> >> @@ -2732,10 +2734,14 @@ static void imx_uart_enable_wakeup(struct
> imx_port *sport, bool on)
> >>   			ucr1 |= UCR1_RTSDEN;
> >>   		} else {
> >>   			ucr1 &= ~UCR1_RTSDEN;
> >> +			wake_active |= !!(usr1 & USR1_RTSD);
> >
> > I think you miss understand my means. suppose bool type only support
> > ||, &&, ==, !=, !
> >
> > 	wake_active = wake_active || (usr1 & USR1_RTSD);
> 
> +1 to this. Much easier to understand (for me at least).

Hi Frank and Jiri, thanks for the suggestions, now I got your point, will fix it in next version.

Best Regards
Sherry