linux-kernel - Re: [PATCH 12/15] serial: sc16is7xx: add missing space between macro args (checkpatch)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a6bb8046-1e71-4766-afa8-e9d303ba57b8@kernel.org>
Date: Mon, 29 Sep 2025 08:15:56 +0200
From: Jiri Slaby <jirislaby@...nel.org>
To: Hugo Villeneuve <hugo@...ovil.com>, gregkh@...uxfoundation.org,
 fvallee@...rea.fr
Cc: linux-kernel@...r.kernel.org, linux-serial@...r.kernel.org,
 Hugo Villeneuve <hvilleneuve@...onoff.com>
Subject: Re: [PATCH 12/15] serial: sc16is7xx: add missing space between macro
 args (checkpatch)

On 24. 09. 25, 17:37, Hugo Villeneuve wrote:
> From: Hugo Villeneuve <hvilleneuve@...onoff.com>
> 
> Fix the following checkpatch error:
> 
>      ERROR: space required after that ',' (ctx:VxV)
>      +#define to_sc16is7xx_one(p,e)...
> 
> Signed-off-by: Hugo Villeneuve <hvilleneuve@...onoff.com>
> ---
>   drivers/tty/serial/sc16is7xx.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/tty/serial/sc16is7xx.c b/drivers/tty/serial/sc16is7xx.c
> index a05be92f7e776..9d04d665ec9ab 100644
> --- a/drivers/tty/serial/sc16is7xx.c
> +++ b/drivers/tty/serial/sc16is7xx.c
> @@ -365,7 +365,7 @@ static struct uart_driver sc16is7xx_uart = {
>   	.nr		= SC16IS7XX_MAX_DEVS,
>   };
>   
> -#define to_sc16is7xx_one(p,e)	((container_of((p), struct sc16is7xx_one, e)))
> +#define to_sc16is7xx_one(p, e)	((container_of((p), struct sc16is7xx_one, e)))

Or perhaps make it type-safe and more obvious by switching it to an inline?

-- 
js
suse labs