lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <70fc7ca0-a98c-4d1b-9212-c7948607e840@kernel.org>
Date: Mon, 29 Sep 2025 08:18:01 +0200
From: Jiri Slaby <jirislaby@...nel.org>
To: Hugo Villeneuve <hugo@...ovil.com>, gregkh@...uxfoundation.org,
 fvallee@...rea.fr
Cc: linux-kernel@...r.kernel.org, linux-serial@...r.kernel.org,
 Hugo Villeneuve <hvilleneuve@...onoff.com>
Subject: Re: [PATCH 14/15] serial: sc16is7xx: reformat comments

On 24. 09. 25, 17:37, Hugo Villeneuve wrote:
> From: Hugo Villeneuve <hvilleneuve@...onoff.com>
> 
> Add missing space at end of comments and reformat to have uniform style.
> 
> Signed-off-by: Hugo Villeneuve <hvilleneuve@...onoff.com>
> ---
>   drivers/tty/serial/sc16is7xx.c | 14 +++++++++-----
>   1 file changed, 9 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/tty/serial/sc16is7xx.c b/drivers/tty/serial/sc16is7xx.c
> index 31d43fc857187..b3fbe9459303a 100644
> --- a/drivers/tty/serial/sc16is7xx.c
> +++ b/drivers/tty/serial/sc16is7xx.c
> @@ -81,11 +81,14 @@
>   /* IER register bits */
>   #define SC16IS7XX_IER_RDI_BIT		BIT(0)   /* Enable RX data interrupt */
>   #define SC16IS7XX_IER_THRI_BIT		BIT(1)   /* Enable TX holding register
> -						  * interrupt */
> +						  * interrupt
> +						  */

I am not forcing this, but maybe put it on one line, if it fits into 100 
columns? I believe people are using 100 columns nowadays (me included).


-- 
js
suse labs

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ