linux-kernel - Re: [PATCH v6 3/4] Manual conversion of ->i

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250929-babysitten-weinlaune-9cf5da52b8b2@brauner>
Date: Mon, 29 Sep 2025 11:30:36 +0200
From: Christian Brauner <brauner@...nel.org>
To: Mateusz Guzik <mjguzik@...il.com>
Cc: viro@...iv.linux.org.uk, jack@...e.cz, linux-kernel@...r.kernel.org, 
	linux-fsdevel@...r.kernel.org, josef@...icpanda.com, kernel-team@...com, amir73il@...il.com, 
	linux-btrfs@...r.kernel.org, linux-ext4@...r.kernel.org, linux-xfs@...r.kernel.org, 
	ceph-devel@...r.kernel.org, linux-unionfs@...r.kernel.org
Subject: Re: [PATCH v6 3/4] Manual conversion of ->i_state uses

On Thu, Sep 25, 2025 at 12:07:13PM +0200, Mateusz Guzik wrote:
> allmodconfig build was done on this patchset but somehow one failure was missed:
> 
> diff --git a/fs/afs/inode.c b/fs/afs/inode.c
> index e9538e91f848..71ec043f7569 100644
> --- a/fs/afs/inode.c
> +++ b/fs/afs/inode.c
> @@ -427,7 +427,7 @@ static void afs_fetch_status_success(struct
> afs_operation *op)
>         struct afs_vnode *vnode = vp->vnode;
>         int ret;
> 
> -       if (vnode->netfs.inode.i_state & I_NEW) {
> +       if (inode_state_read(&vnode->netfs.inode) & I_NEW) {
>                 ret = afs_inode_init_from_status(op, vp, vnode);
>                 afs_op_set_error(op, ret);
>                 if (ret == 0)
> 
> 
> I reran the thing with this bit and now it's all clean. I think this
> can be folded into the manual fixup patch (the one i'm responding to)
> instead of resending the patchset

Folded, thanks!