linux-kernel - Re: [PATCH -next] nvdimm: Remove duplicate linux/slab.h header

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aNrAnhYMyvZ-farN@aschofie-mobl2.lan>
Date: Mon, 29 Sep 2025 10:23:42 -0700
From: Alison Schofield <alison.schofield@...el.com>
To: Ira Weiny <ira.weiny@...el.com>
CC: Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>,
	<dan.j.williams@...el.com>, <vishal.l.verma@...el.com>,
	<dave.jiang@...el.com>, <nvdimm@...ts.linux.dev>,
	<linux-kernel@...r.kernel.org>, Abaci Robot <abaci@...ux.alibaba.com>
Subject: Re: [PATCH -next] nvdimm: Remove duplicate linux/slab.h header

On Mon, Sep 29, 2025 at 10:05:31AM -0500, Ira Weiny wrote:
> Alison Schofield wrote:
> > On Sun, Sep 28, 2025 at 09:31:10AM +0800, Jiapeng Chong wrote:
> > > ./drivers/nvdimm/bus.c: linux/slab.h is included more than once.
> > 
> > Hi Jiapeng,
> > 
> > It would have been useful here to note where else slab.h was included,
> > since it wasn't simply a duplicate #include in bus.c.
> 
> Actually Alison this is a bug against linux-next where it was an issue
> with Dave's patch here:
> 
> https://lore.kernel.org/all/20250923174013.3319780-3-dave.jiang@intel.com/

Ah, I see this removes the dup that the above patch added.

Why not remove fs.h instead of slab.h and get a clean up and de-dup
in one shot?

> 
> I'll queue this up.
> 
> Reviewed-by: Ira Weiny <ira.weiny@...el.com>
> 
> Thanks,
> Ira
> 
> > 
> > I found slab.h is also in #include <linux/fs.h>. Then I found that this
> > compiles if I remove both of those includes. It would be worthwhile to
> > check all the includes and send a new tested version of this patch that
> > does this "Remove needless #include's in bus.c"
> > 
> > BTW - I didn't check all #includes.There may be more beyond slab.h & fs.h.
> > 
> > --Alison
> > 
> > > 
> > > Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
> > > Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=25516
> > > Signed-off-by: Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>
> > > ---
> > >  drivers/nvdimm/bus.c | 1 -
> > >  1 file changed, 1 deletion(-)
> > > 
> > > diff --git a/drivers/nvdimm/bus.c b/drivers/nvdimm/bus.c
> > > index ad3a0493f474..87178a53ff9c 100644
> > > --- a/drivers/nvdimm/bus.c
> > > +++ b/drivers/nvdimm/bus.c
> > > @@ -13,7 +13,6 @@
> > >  #include <linux/async.h>
> > >  #include <linux/ndctl.h>
> > >  #include <linux/sched.h>
> > > -#include <linux/slab.h>
> > >  #include <linux/cpu.h>
> > >  #include <linux/fs.h>
> > >  #include <linux/io.h>
> > > -- 
> > > 2.43.5
> > > 
> > > 
> 
>