linux-kernel - Re: [PATCH -next] nvdimm: Remove duplicate linux/slab.h header

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <68dc30bacdee2_1fa2100c4@dwillia2-mobl4.notmuch>
Date: Tue, 30 Sep 2025 12:34:18 -0700
From: <dan.j.williams@...el.com>
To: Alison Schofield <alison.schofield@...el.com>, Ira Weiny
	<ira.weiny@...el.com>
CC: Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>,
	<dan.j.williams@...el.com>, <vishal.l.verma@...el.com>,
	<dave.jiang@...el.com>, <nvdimm@...ts.linux.dev>,
	<linux-kernel@...r.kernel.org>, Abaci Robot <abaci@...ux.alibaba.com>
Subject: Re: [PATCH -next] nvdimm: Remove duplicate linux/slab.h header

Alison Schofield wrote:
> On Mon, Sep 29, 2025 at 10:05:31AM -0500, Ira Weiny wrote:
> > Alison Schofield wrote:
> > > On Sun, Sep 28, 2025 at 09:31:10AM +0800, Jiapeng Chong wrote:
> > > > ./drivers/nvdimm/bus.c: linux/slab.h is included more than once.
> > > 
> > > Hi Jiapeng,
> > > 
> > > It would have been useful here to note where else slab.h was included,
> > > since it wasn't simply a duplicate #include in bus.c.
> > 
> > Actually Alison this is a bug against linux-next where it was an issue
> > with Dave's patch here:
> > 
> > https://lore.kernel.org/all/20250923174013.3319780-3-dave.jiang@intel.com/
> 
> Ah, I see this removes the dup that the above patch added.
> 
> Why not remove fs.h instead of slab.h and get a clean up and de-dup
> in one shot?

fs.h is included for 'struct file_operations', so no clean up
opportunity there. Recall the "include what you use" recommendation:

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submit-checklist.rst?id=v6.17-rc7#n17