linux-kernel - Re: [PATCH] PCI: ixp4xx: Guard ARM32-specific hook_fault

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdZFy2Kb0BaEkMiTi3j89H-6G=chuZSijtRRg7QCCktLDA@mail.gmail.com>
Date: Tue, 30 Sep 2025 20:59:36 +0200
From: Linus Walleij <linus.walleij@...aro.org>
To: Bjorn Helgaas <helgaas@...nel.org>, Russell King <rmk+kernel@...linux.org.uk>
Cc: Lorenzo Pieralisi <lpieralisi@...nel.org>, Krzysztof Wilczyński <kwilczynski@...nel.org>, 
	Manivannan Sadhasivam <mani@...nel.org>, Rob Herring <robh@...nel.org>, linux-pci@...r.kernel.org, 
	linux-kernel@...r.kernel.org, Bjorn Helgaas <bhelgaas@...gle.com>
Subject: Re: [PATCH] PCI: ixp4xx: Guard ARM32-specific hook_fault_code()

On Thu, Sep 25, 2025 at 10:27 PM Bjorn Helgaas <helgaas@...nel.org> wrote:

> From: Bjorn Helgaas <bhelgaas@...gle.com>
>
> hook_fault_code() is an ARM32-specific API.  Guard it and related code with
> CONFIG_ARM #ifdefs so the driver can be compile tested on other
> architectures.
>
> Signed-off-by: Bjorn Helgaas <bhelgaas@...gle.com>

It looks OK to me
Acked-by: Linus Walleij <linus.walleij@...ar.org>

I see some other ARM32 drivers use it too, but we surely do
not have a arch-agnostic way of handling bus errors so perhaps it
need to be like this.

I think Russell created the fault hooks originally so CC:ing him
in.

Yours,
Linus Walleij