lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <687549ed-7610-4bd8-ba30-854c99868cc1@gmail.com>
Date: Tue, 30 Sep 2025 04:29:26 -0400
From: Vivek BalachandharTN <vivek.balachandhar@...il.com>
To: Greg KH <gregkh@...uxfoundation.org>
Cc: linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 04/15] staging: rtl8723bs: align asterisk in block
 comment to fix formatting

Thanks for pointing it out. Ack. I’ll wait for more comments from the 
community for another three days and then will send the next version.

Best, Vivek

On 2025-09-29 2:58 a.m., Greg KH wrote:
> On Mon, Sep 29, 2025 at 06:49:49AM +0000, Vivek BalachandharTN wrote:
>> Align the leading asterisks in a multi-line block comment to maintain
>> consistent formatting and improve readability,in accordance with kernel
>> coding style guidelines. No functional changes.
>>
>> Signed-off-by: Vivek BalachandharTN <vivek.balachandhar@...il.com>
>> ---
>>   drivers/staging/rtl8723bs/core/rtw_mlme.c | 40 +++++++++++------------
>>   1 file changed, 20 insertions(+), 20 deletions(-)
>>
>> diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme.c b/drivers/staging/rtl8723bs/core/rtw_mlme.c
>> index 3eeea832dcb6..cd41f713a52e 100644
>> --- a/drivers/staging/rtl8723bs/core/rtw_mlme.c
>> +++ b/drivers/staging/rtl8723bs/core/rtw_mlme.c
>> @@ -869,8 +869,8 @@ static void find_network(struct adapter *adapter)
>>   }
>>   
>>   /*
>> -*rtw_free_assoc_resources: the caller has to lock pmlmepriv->lock
>> -*/
>> + *rtw_free_assoc_resources: the caller has to lock pmlmepriv->lock
> Shouldn't you also have a space after the '*' and before the 'r'?
>
> thanks,
>
> greg k-h

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ