lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [day] [month] [year] [list]
Message-ID:
 <VI1PR02MB395245DCA7CA4B6DEA15F1ED9C1AA@VI1PR02MB3952.eurprd02.prod.outlook.com>
Date: Tue, 30 Sep 2025 09:57:09 +0000
From: David Binderman <dcb314@...mail.com>
To: "mic@...ikod.net" <mic@...ikod.net>, "gnoack@...gle.com"
	<gnoack@...gle.com>, "shuah@...nel.org" <shuah@...nel.org>,
	"linux-security-module@...r.kernel.org"
	<linux-security-module@...r.kernel.org>, "linux-kselftest@...r.kernel.org"
	<linux-kselftest@...r.kernel.org>, LKML <linux-kernel@...r.kernel.org>
Subject: linux-6.17/tools/testing/selftests/landlock/fs_test.c:5631: Test for
 pointer < 0 ?

Hello there,

Static analyser cppcheck says:

linux-6.17/tools/testing/selftests/landlock/fs_test.c:5631:23: style: A pointer can not be negative so it is either pointless or an error to check if it is. [pointerLessThanZero]

Source code is

    if (log_match_cursor < 0)
        return (long long)log_match_cursor;

but

    char *log_match_cursor = log_match;

Suggest remove code.

Regards

David Binderman

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ