[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <f5c5254c-537e-46ad-a7cb-a8b18b07632c@linaro.org>
Date: Tue, 30 Sep 2025 12:57:02 +0300
From: Eugen Hristev <eugen.hristev@...aro.org>
To: Raviteja Laggyshetty <raviteja.laggyshetty@....qualcomm.com>,
Konrad Dybcio <konrad.dybcio@....qualcomm.com>,
Jingyi Wang <jingyi.wang@....qualcomm.com>, Georgi Djakov
<djakov@...nel.org>, Rob Herring <robh@...nel.org>,
Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>
Cc: linux-arm-msm@...r.kernel.org, linux-pm@...r.kernel.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
aiqun.yu@....qualcomm.com, tingwei.zhang@....qualcomm.com,
trilok.soni@....qualcomm.com, yijie.yang@....qualcomm.com
Subject: Re: [PATCH 1/2] dt-bindings: interconnect: document the RPMh
Network-On-Chip interconnect in Kaanapali SoC
On 9/30/25 06:06, Raviteja Laggyshetty wrote:
>
>
> On 9/25/2025 6:10 PM, Konrad Dybcio wrote:
>> On 9/25/25 10:57 AM, Eugen Hristev wrote:
>>>
>>>
>>> On 9/25/25 02:02, Jingyi Wang wrote:
>>>> From: Raviteja Laggyshetty <raviteja.laggyshetty@....qualcomm.com>
>>>>
>>>> Document the RPMh Network-On-Chip Interconnect of the Kaanapali platform.
>>>>
>>>> Signed-off-by: Raviteja Laggyshetty <raviteja.laggyshetty@....qualcomm.com>
>>>> Signed-off-by: Jingyi Wang <jingyi.wang@....qualcomm.com>
>>>> ---
>>
>> [...]
>>
>>>> +properties:
>>>> + compatible:
>>>> + enum:
>>>> + - qcom,kaanapali-aggre-noc
>>>
>>> Hi,
>>>
>>> Does Kaanapali have a single aggre node, or there are several ?
>>> On previous SoC, I see there are two (aggre1 and aggre2).
>>> Also in your driver (second patch), I notice aggre1_noc and aggre2_noc .
>>> It would make sense to accurately describe here the hardware.
>>
>> They're physically separate
>>
> Yes, they are physically separate but the topology treats them as a single noc
> with two slave connections to system noc which you have noticed in the topology file.
Is it any difference from previous sm8750 where there are two nodes ?
If yes, can you mention the difference and reasoning for merging them
into a single node.
If no, can you reason why the decision to merge them into a single node
this time instead of keeping it consistent ?
>
> Thanks,
> Raviteja.
>
>> Konrad
Powered by blists - more mailing lists