linux-kernel - Re: [PATCH v3 02/10] tpm: Use -EPERM as fallback error code in tpm_ret_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aNvPBeldvMR5IjIq@kernel.org>
Date: Tue, 30 Sep 2025 15:37:25 +0300
From: Jarkko Sakkinen <jarkko@...nel.org>
To: Stefano Garzarella <sgarzare@...hat.com>
Cc: linux-integrity@...r.kernel.org, dpsmith@...rtussolutions.com,
	ross.philipson@...cle.com,
	Jarkko Sakkinen <jarkko.sakkinen@...nsys.com>,
	Peter Huewe <peterhuewe@....de>, Jason Gunthorpe <jgg@...pe.ca>,
	David Howells <dhowells@...hat.com>,
	Paul Moore <paul@...l-moore.com>, James Morris <jmorris@...ei.org>,
	"Serge E. Hallyn" <serge@...lyn.com>,
	open list <linux-kernel@...r.kernel.org>,
	"open list:KEYS/KEYRINGS" <keyrings@...r.kernel.org>,
	"open list:SECURITY SUBSYSTEM" <linux-security-module@...r.kernel.org>
Subject: Re: [PATCH v3 02/10] tpm: Use -EPERM as fallback error code in
 tpm_ret_to_err

On Tue, Sep 30, 2025 at 02:11:23PM +0200, Stefano Garzarella wrote:
> On Mon, Sep 29, 2025 at 10:48:24PM +0300, Jarkko Sakkinen wrote:
> > From: Jarkko Sakkinen <jarkko.sakkinen@...nsys.com>
> > 
> > Using -EFAULT as the tpm_ret_to_err() fallback error code causes makes it
> > incompatible on how trusted keys transmute TPM return codes.
> > 
> > Change the fallback as -EPERM in order to gain compatibility with trusted
> > keys. In addition, map TPM_RC_HASH to -EINVAL in order to be compatible
> > with tpm2_seal_trusted() return values.
> > 
> > Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@...nsys.com>
> > ---
> > v3:
> > - Removed fixes tag as it hardly categorizes as a bug fix.
> > v2:
> > - Split trusted_tpm2 change to a separate patch.
> > ---
> > include/linux/tpm.h | 4 +++-
> > 1 file changed, 3 insertions(+), 1 deletion(-)
> 
> LGTM now!
> 
> Reviewed-by: Stefano Garzarella <sgarzare@...hat.com>

Thank you.

> 
> > 
> > diff --git a/include/linux/tpm.h b/include/linux/tpm.h
> > index fc7df87dfb9a..51846317d662 100644
> > --- a/include/linux/tpm.h
> > +++ b/include/linux/tpm.h
> > @@ -453,8 +453,10 @@ static inline ssize_t tpm_ret_to_err(ssize_t ret)
> > 		return 0;
> > 	case TPM2_RC_SESSION_MEMORY:
> > 		return -ENOMEM;
> > +	case TPM2_RC_HASH:
> > +		return -EINVAL;
> > 	default:
> > -		return -EFAULT;
> > +		return -EPERM;
> > 	}
> > }
> > 
> > -- 
> > 2.39.5
> > 
> > 
> 

BR, Jarkko