[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20251001003841.510494-1-safinaskar@gmail.com>
Date: Wed, 1 Oct 2025 03:38:41 +0300
From: Askar Safin <safinaskar@...il.com>
To: cyphar@...har.com
Cc: alx@...nel.org,
brauner@...nel.org,
dhowells@...hat.com,
g.branden.robinson@...il.com,
jack@...e.cz,
linux-api@...r.kernel.org,
linux-fsdevel@...r.kernel.org,
linux-kernel@...r.kernel.org,
linux-man@...r.kernel.org,
mtk.manpages@...il.com,
viro@...iv.linux.org.uk
Subject: Re: [PATCH v5 7/8] man/man2/open_tree{,_attr}.2: document new open_tree_attr() API
Aleksa Sarai <cyphar@...har.com>:
> +mntfd2 = open_tree(mntfd1, "", OPEN_TREE_CLONE,
> + &attr, sizeof(attr));
Your whole so-called "open_tree_attr example" doesn't contain any open_tree_attr
calls. :)
I think you meant open_tree_attr here.
> +\&
> +/* Create a new copy with the id-mapping cleared */
> +memset(&attr, 0, sizeof(attr));
> +attr.attr_clr = MOUNT_ATTR_IDMAP;
> +mntfd3 = open_tree(mntfd1, "", OPEN_TREE_CLONE,
> + &attr, sizeof(attr));
And here.
Otherwise your whole patchset looks good. Add to whole patchset:
Reviewed-by: Askar Safin <safinaskar@...il.com>
--
Askar Safin
Powered by blists - more mailing lists