linux-kernel - Re: [PATCH] mfd: macsmc: Initialize mutex

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0acf13d6-d63b-4079-93ba-d53910e624d7@web.de>
Date: Wed, 1 Oct 2025 13:13:44 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: Lee Jones <lee@...nel.org>, Janne Grunau <j@...nau.net>,
 asahi@...ts.linux.dev, linux-arm-kernel@...ts.infradead.org
Cc: LKML <linux-kernel@...r.kernel.org>, Neal Gompa <neal@...pa.dev>,
 Sven Peter <sven@...nel.org>
Subject: Re: [PATCH] mfd: macsmc: Initialize mutex

>>> Struct apple_smc's mutex was not initialized before use. Surprisingly
>>> this only resulted in occasional NULL pointer dereferences in
>>> apple_smc_read() calls from the probe() functions of sub devices.
>>
>> See also:
>> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.17-rc7#n94
> 
> Provide some context in your own words.

Would contributors like to care more also for the usage of imperative mood
in proposed commit messages?


> Don't expect others to click random links.

Should the mentioned information source be better known since a while?

Regards,
Markus