linux-kernel - Re: [PATCH] mfd: macsmc: Initialize mutex

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251001124825.GR8757@google.com>
Date: Wed, 1 Oct 2025 13:48:25 +0100
From: Lee Jones <lee@...nel.org>
To: Markus Elfring <Markus.Elfring@....de>
Cc: Janne Grunau <j@...nau.net>, asahi@...ts.linux.dev,
	linux-arm-kernel@...ts.infradead.org,
	LKML <linux-kernel@...r.kernel.org>, Neal Gompa <neal@...pa.dev>,
	Sven Peter <sven@...nel.org>
Subject: Re: [PATCH] mfd: macsmc: Initialize mutex

On Wed, 01 Oct 2025, Markus Elfring wrote:

> >>> Struct apple_smc's mutex was not initialized before use. Surprisingly
> >>> this only resulted in occasional NULL pointer dereferences in
> >>> apple_smc_read() calls from the probe() functions of sub devices.
> >>
> >> See also:
> >> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.17-rc7#n94
> > 
> > Provide some context in your own words.
> 
> Would contributors like to care more also for the usage of imperative mood
> in proposed commit messages?
> 
> 
> > Don't expect others to click random links.
> 
> Should the mentioned information source be better known since a while?

By all means, provide the link as well.

However, you must also provide your own context.

-- 
Lee Jones [李琼斯]