linux-kernel - Re: [PATCH 07/12] unwind: Clarify calling context

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251001113849.65a95421@gandalf.local.home>
Date: Wed, 1 Oct 2025 11:38:49 -0400
From: Steven Rostedt <rostedt@...dmis.org>
To: Peter Zijlstra <peterz@...radead.org>
Cc: jpoimboe@...nel.org, rostedt@...nel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 07/12] unwind: Clarify calling context

On Wed, 24 Sep 2025 09:59:55 +0200
Peter Zijlstra <peterz@...radead.org> wrote:

> The get_cookie() function hard relies on IRQs being disabled, but this
> isn't immediately obvious when reading the function.
> 
> Signed-off-by: Peter Zijlstra (Intel) <peterz@...radead.org>

Acked-by: Steven Rostedt (Google) <rostedt@...dmis.org>

-- Steve

> ---
>  kernel/unwind/deferred.c |    2 ++
>  1 file changed, 2 insertions(+)
> 
> --- a/kernel/unwind/deferred.c
> +++ b/kernel/unwind/deferred.c
> @@ -79,6 +79,8 @@ static u64 get_cookie(struct unwind_task
>  {
>  	u32 cnt = 1;
>  
> +	lockdep_assert_irqs_disabled();
> +
>  	if (info->id.cpu)
>  		return info->id.id;
>  
>