linux-kernel - Re: [PATCH v1 1/2] spi: dt-bindings: cadence: add soc-specific compatible strings for zynqmp and versal-net

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1a46a515-d85a-40c5-8cd6-f4d0330fa4aa@amd.com>
Date: Thu, 2 Oct 2025 08:05:32 +0200
From: Michal Simek <michal.simek@....com>
To: Conor Dooley <conor@...nel.org>, linux-spi@...r.kernel.org
Cc: Conor Dooley <conor.dooley@...rochip.com>, Jun Guo <Jun.Guo@...tech.com>,
 Mark Brown <broonie@...nel.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v1 1/2] spi: dt-bindings: cadence: add soc-specific
 compatible strings for zynqmp and versal-net



On 10/1/25 20:31, Conor Dooley wrote:
> From: Conor Dooley <conor.dooley@...rochip.com>
> 
> When the binding for the Cadence spi controller was written, a dedicated
> compatible was added for the zynq device. Later when zynqmp and
> versal-net, which also use this spi controller IP, were added they did
> not receive soc-specific compatibles. Add them now, with a fallback to
> the existing compatible for the r1p6 version of the IP so that there
> will be no functional change. Retain the r1p6 in the string, to match
> what was done for zynq.
> 
> Disallow the cdns,spi-r1p6 compatible in isolation to "encourage" people
> to actually add soc-specific compatible strings in the future.
> 
> Signed-off-by: Conor Dooley <conor.dooley@...rochip.com>
> ---
> CC: Jun Guo <Jun.Guo@...tech.com>
> CC: Mark Brown <broonie@...nel.org>
> CC: Rob Herring <robh@...nel.org>
> CC: Krzysztof Kozlowski <krzk+dt@...nel.org>
> CC: Conor Dooley <conor+dt@...nel.org>
> CC: Michal Simek <michal.simek@....com>
> CC: linux-spi@...r.kernel.org
> CC: devicetree@...r.kernel.org
> CC: linux-kernel@...r.kernel.org
> CC: linux-arm-kernel@...ts.infradead.org
> ---
>   .../devicetree/bindings/spi/spi-cadence.yaml          | 11 ++++++++---
>   1 file changed, 8 insertions(+), 3 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/spi/spi-cadence.yaml b/Documentation/devicetree/bindings/spi/spi-cadence.yaml
> index 8de96abe9da1..27414b78d61d 100644
> --- a/Documentation/devicetree/bindings/spi/spi-cadence.yaml
> +++ b/Documentation/devicetree/bindings/spi/spi-cadence.yaml
> @@ -14,9 +14,14 @@ allOf:
>   
>   properties:
>     compatible:
> -    enum:
> -      - cdns,spi-r1p6
> -      - xlnx,zynq-spi-r1p6
> +    oneOf:
> +      - enum:
> +          - xlnx,zynq-spi-r1p6
> +      - items:
> +          - enum:
> +              - xlnx,zynqmp-spi-r1p6
> +              - xlnx,versal-net-spi-r1p6
> +          - const: cdns,spi-r1p6
>   
>     reg:
>       maxItems: 1

Acked-by: Michal Simek <michal.simek@....com>

Thanks,
Michal