linux-kernel - Re: [PATCH v1 2/2] arm64: dts: xilinx: add soc-specific spi compatibles for zynqmp/versal-net

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <101a83ba-cd2b-4080-aaa3-630652c33786@amd.com>
Date: Thu, 2 Oct 2025 08:06:47 +0200
From: Michal Simek <michal.simek@....com>
To: Conor Dooley <conor@...nel.org>, linux-spi@...r.kernel.org
Cc: Conor Dooley <conor.dooley@...rochip.com>, Jun Guo <Jun.Guo@...tech.com>,
 Mark Brown <broonie@...nel.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v1 2/2] arm64: dts: xilinx: add soc-specific spi
 compatibles for zynqmp/versal-net



On 10/1/25 20:31, Conor Dooley wrote:
> From: Conor Dooley <conor.dooley@...rochip.com>
> 
> Unlike zynq, which has a specific compatible for the Cadence spi
> controller, zynqmp and versal-net do not have specific compatibles.
> In order to "encourage" people to use soc-specific compatibles for new
> devices using this IP, add specific compatibles for these devices, with
> a fallback to the existing compatible for the r1p6 version of the IP so
> that there will be no functional change.
> 
> Signed-off-by: Conor Dooley <conor.dooley@...rochip.com>
> ---
> CC: Jun Guo <Jun.Guo@...tech.com>
> CC: Mark Brown <broonie@...nel.org>
> CC: Rob Herring <robh@...nel.org>
> CC: Krzysztof Kozlowski <krzk+dt@...nel.org>
> CC: Conor Dooley <conor+dt@...nel.org>
> CC: Michal Simek <michal.simek@....com>
> CC: linux-spi@...r.kernel.org
> CC: devicetree@...r.kernel.org
> CC: linux-kernel@...r.kernel.org
> CC: linux-arm-kernel@...ts.infradead.org
> ---
>   arch/arm64/boot/dts/xilinx/versal-net.dtsi | 4 ++--
>   arch/arm64/boot/dts/xilinx/zynqmp.dtsi     | 4 ++--
>   2 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/xilinx/versal-net.dtsi b/arch/arm64/boot/dts/xilinx/versal-net.dtsi
> index fc9f49e57385..38af1a4e34f7 100644
> --- a/arch/arm64/boot/dts/xilinx/versal-net.dtsi
> +++ b/arch/arm64/boot/dts/xilinx/versal-net.dtsi
> @@ -610,7 +610,7 @@ smmu: iommu@...00000 {
>   		};
>   
>   		spi0: spi@...60000 {
> -			compatible = "cdns,spi-r1p6";
> +			compatible = "xlnx,versal-net-spi-r1p6", "cdns,spi-r1p6";
>   			status = "disabled";
>   			interrupts = <0 23 4>;
>   			reg = <0 0xf1960000 0 0x1000>;
> @@ -618,7 +618,7 @@ spi0: spi@...60000 {
>   		};
>   
>   		spi1: spi@...70000 {
> -			compatible = "cdns,spi-r1p6";
> +			compatible = "xlnx,versal-net-spi-r1p6", "cdns,spi-r1p6";
>   			status = "disabled";
>   			interrupts = <0 24 4>;
>   			reg = <0 0xf1970000 0 0x1000>;
> diff --git a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi b/arch/arm64/boot/dts/xilinx/zynqmp.dtsi
> index e11d282462bd..89c565bef274 100644
> --- a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi
> +++ b/arch/arm64/boot/dts/xilinx/zynqmp.dtsi
> @@ -1076,7 +1076,7 @@ smmu: iommu@...00000 {
>   		};
>   
>   		spi0: spi@...40000 {
> -			compatible = "cdns,spi-r1p6";
> +			compatible = "xlnx,zynqmp-spi-r1p6", "cdns,spi-r1p6";
>   			status = "disabled";
>   			interrupt-parent = <&gic>;
>   			interrupts = <GIC_SPI 19 IRQ_TYPE_LEVEL_HIGH>;
> @@ -1088,7 +1088,7 @@ spi0: spi@...40000 {
>   		};
>   
>   		spi1: spi@...50000 {
> -			compatible = "cdns,spi-r1p6";
> +			compatible = "xlnx,zynqmp-spi-r1p6", "cdns,spi-r1p6";
>   			status = "disabled";
>   			interrupt-parent = <&gic>;
>   			interrupts = <GIC_SPI 20 IRQ_TYPE_LEVEL_HIGH>;

Acked-by: Michal Simek <michal.simek@....com>

Do you expect to go via SPI tree or via SOC tree?

Thanks,
Michal