[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <bb66bc81-2b20-48bb-87bd-6c34b35f4cd8@collabora.com>
Date: Thu, 2 Oct 2025 16:36:02 +0300
From: Dmitry Osipenko <dmitry.osipenko@...labora.com>
To: Sebastian Reichel <sebastian.reichel@...labora.com>
Cc: Mauro Carvalho Chehab <mchehab@...nel.org>,
Hans Verkuil <hverkuil@...all.nl>, jose.abreu@...opsys.com,
nelson.costa@...opsys.com, shawn.wen@...k-chips.com,
nicolas.dufresne@...labora.com, kernel@...labora.com,
linux-media@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-rockchip@...ts.infradead.org
Subject: Re: [PATCH v1] media: synopsys: hdmirx: Detect broken interrupt
Hi,
On 10/2/25 16:18, Sebastian Reichel wrote:
>> + *val = status & PHYCREG_CR_PARA_RD_DATA_MASK;
>> +
>> + return 0;
>> +}
> Do you expect this to be used in other places in the driver? In that
> case there should probably be some locking, since the hardware interface
> obviously cannot handle concurrency. Otherwise maybe add a comment,
> that the function may not be called if concurrency is possible?
Don't expect this function to be used in other places and haven't added
locking on purpose to keep the code cleaner. Will add the comment.
Thanks for all suggestions.
--
Best regards,
Dmitry
Powered by blists - more mailing lists