linux-kernel - Re: [PATCH v1] media: synopsys: hdmirx: Detect broken interrupt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <90043066-055d-43a1-97c9-dee118b8a101@collabora.com>
Date: Thu, 2 Oct 2025 16:56:31 +0300
From: Dmitry Osipenko <dmitry.osipenko@...labora.com>
To: Sebastian Reichel <sebastian.reichel@...labora.com>
Cc: Mauro Carvalho Chehab <mchehab@...nel.org>,
 Hans Verkuil <hverkuil@...all.nl>, jose.abreu@...opsys.com,
 nelson.costa@...opsys.com, shawn.wen@...k-chips.com,
 nicolas.dufresne@...labora.com, kernel@...labora.com,
 linux-media@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-rockchip@...ts.infradead.org
Subject: Re: [PATCH v1] media: synopsys: hdmirx: Detect broken interrupt

On 10/2/25 16:36, Dmitry Osipenko wrote:
> Hi,
> 
> On 10/2/25 16:18, Sebastian Reichel wrote:
>>> +	*val = status & PHYCREG_CR_PARA_RD_DATA_MASK;
>>> +
>>> +	return 0;
>>> +}
>> Do you expect this to be used in other places in the driver? In that
>> case there should probably be some locking, since the hardware interface
>> obviously cannot handle concurrency. Otherwise maybe add a comment,
>> that the function may not be called if concurrency is possible?
> 
> Don't expect this function to be used in other places and haven't added
> locking on purpose to keep the code cleaner. Will add the comment.
> 
> Thanks for all suggestions.
> 

On a second thought, this would be a case where the guard() thingy would
be useful and help keeping code clean, will use it in v2.

-- 
Best regards,
Dmitry