[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <aN6hFCYJy-XjROFP@jlelli-thinkpadt14gen4.remote.csb>
Date: Thu, 2 Oct 2025 16:58:12 +0100
From: Juri Lelli <juri.lelli@...hat.com>
To: Yuri Andriaccio <yurand2000@...il.com>
Cc: Ingo Molnar <mingo@...hat.com>, Peter Zijlstra <peterz@...radead.org>,
Vincent Guittot <vincent.guittot@...aro.org>,
Dietmar Eggemann <dietmar.eggemann@....com>,
Steven Rostedt <rostedt@...dmis.org>,
Ben Segall <bsegall@...gle.com>, Mel Gorman <mgorman@...e.de>,
Valentin Schneider <vschneid@...hat.com>,
linux-kernel@...r.kernel.org,
Luca Abeni <luca.abeni@...tannapisa.it>,
Yuri Andriaccio <yuri.andriaccio@...tannapisa.it>
Subject: Re: [RFC PATCH v3 06/24] sched/rt: Introduce HCBS specific structs
in task_group
Hello,
On 29/09/25 11:22, Yuri Andriaccio wrote:
> From: luca abeni <luca.abeni@...tannapisa.it>
>
> Each task_group manages a number of new objects:
> - a sched_dl_entity/dl_server for each CPU
> - a dl_bandwidth object to keep track of its allocated dl_bandwidth
>
> Co-developed-by: Alessio Balsini <a.balsini@...up.it>
> Signed-off-by: Alessio Balsini <a.balsini@...up.it>
> Co-developed-by: Andrea Parri <parri.andrea@...il.com>
> Signed-off-by: Andrea Parri <parri.andrea@...il.com>
> Co-developed-by: Yuri Andriaccio <yurand2000@...il.com>
> Signed-off-by: Yuri Andriaccio <yurand2000@...il.com>
> Signed-off-by: luca abeni <luca.abeni@...tannapisa.it>
> ---
...
> @@ -467,10 +474,17 @@ struct task_group {
> #endif /* CONFIG_FAIR_GROUP_SCHED */
>
> #ifdef CONFIG_RT_GROUP_SCHED
> + /*
> + * Each task group manages a different scheduling entity per CPU, i.e. a
> + * different deadline server, and a runqueue per CPU. All the dl-servers
> + * share the same dl_bandwidth object.
> + */
> struct sched_rt_entity **rt_se;
> + struct sched_dl_entity **dl_se;
> struct rt_rq **rt_rq;
>
> struct rt_bandwidth rt_bandwidth;
> + struct dl_bandwidth dl_bandwidth;
> #endif
>
> struct scx_task_group scx;
> @@ -817,12 +831,12 @@ struct rt_rq {
> raw_spinlock_t rt_runtime_lock;
>
> unsigned int rt_nr_boosted;
> -
> - struct rq *rq; /* this is always top-level rq, cache? */
> #endif
> #ifdef CONFIG_CGROUP_SCHED
> struct task_group *tg; /* this tg has "this" rt_rq on given CPU for runnable entities */
> #endif
> +
> + struct rq *rq; /* cgroup's runqueue if the rt_rq entity belongs to a cgroup, otherwise top-level rq */
The comment really wants to span multiple lines, maybe above the
pointer.
Thanks,
Juri
Powered by blists - more mailing lists