linux-kernel - Re: [PATCH 1/1 v2] tools build: Don't assume libtracefs-devel is always available

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAP-5=fWBCcwF9jcOh+vWwKU0P04oiTSu2n+bO+X3SaqeDLtx=A@mail.gmail.com>
Date: Thu, 2 Oct 2025 08:56:56 -0700
From: Ian Rogers <irogers@...gle.com>
To: Arnaldo Carvalho de Melo <acme@...nel.org>
Cc: Namhyung Kim <namhyung@...nel.org>, Tomas Glozar <tglozar@...hat.com>, 
	Adrian Hunter <adrian.hunter@...el.com>, Gabriele Monaco <gmonaco@...hat.com>, 
	James Clark <james.clark@...aro.org>, Jiri Olsa <jolsa@...nel.org>, 
	Kan Liang <kan.liang@...ux.intel.com>, Steven Rostedt <rostedt@...dmis.org>, 
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, linux-perf-users@...r.kernel.org
Subject: Re: [PATCH 1/1 v2] tools build: Don't assume libtracefs-devel is
 always available

On Thu, Oct 2, 2025 at 8:47 AM Arnaldo Carvalho de Melo <acme@...nel.org> wrote:
>
> perf doesn't use libtracefs and so it doesn't make sense to assume it is
> always available when building test-all.bin, defeating the feature check
> speedup it provides.
>
> The other tools/build/ users such as rtla, rv, etc call $(feature_check
> libtracefs) to check its availability instead of using the test-all.bin
> mechanism, stopping the build and asking for libtracefs-devel to be
> installed.
>
> Remove it from FEATURE_TESTS_BASIC to not have it as available, as noted
> by Ian Rogers during review.
>
> Acked-by: Tomas Glozar <tglozar@...hat.com>
> Cc: Adrian Hunter <adrian.hunter@...el.com>
> Cc: Gabriele Monaco <gmonaco@...hat.com>
> Cc: Ian Rogers <irogers@...gle.com>
> Cc: James Clark <james.clark@...aro.org>
> Cc: Jiri Olsa <jolsa@...nel.org>
> Cc: Kan Liang <kan.liang@...ux.intel.com>
> Cc: Namhyung Kim <namhyung@...nel.org>
> Cc: Steven Rostedt <rostedt@...dmis.org>
> Signed-off-by: Arnaldo Carvalho de Melo <acme@...hat.com>

Reviewed-by: Ian Rogers <irogers@...gle.com>

Thanks!
Ian

> ---
>  tools/build/Makefile.feature   | 1 -
>  tools/build/feature/test-all.c | 5 -----
>  2 files changed, 6 deletions(-)
>
> diff --git a/tools/build/Makefile.feature b/tools/build/Makefile.feature
> index 9c1a69d26f5121fd..531f8fc4f7df9943 100644
> --- a/tools/build/Makefile.feature
> +++ b/tools/build/Makefile.feature
> @@ -83,7 +83,6 @@ FEATURE_TESTS_BASIC :=                  \
>          libpython                       \
>          libslang                        \
>          libtraceevent                   \
> -        libtracefs                      \
>          libcpupower                     \
>          pthread-attr-setaffinity-np     \
>          pthread-barrier                \
> diff --git a/tools/build/feature/test-all.c b/tools/build/feature/test-all.c
> index e1847db6f8e63750..2df593593b6ec15e 100644
> --- a/tools/build/feature/test-all.c
> +++ b/tools/build/feature/test-all.c
> @@ -150,10 +150,6 @@
>  # include "test-libtraceevent.c"
>  #undef main
>
> -#define main main_test_libtracefs
> -# include "test-libtracefs.c"
> -#undef main
> -
>  int main(int argc, char *argv[])
>  {
>         main_test_libpython();
> @@ -187,7 +183,6 @@ int main(int argc, char *argv[])
>         main_test_reallocarray();
>         main_test_libzstd();
>         main_test_libtraceevent();
> -       main_test_libtracefs();
>
>         return 0;
>  }
> --
> 2.49.0
>