linux-kernel - Re: [PATCH] cifs: Fix copy_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20251005135132.33612-1-wangfushuai@baidu.com>
Date: Sun, 5 Oct 2025 21:51:32 +0800
From: Fushuai Wang <wangfushuai@...du.com>
To: <markus.elfring@....de>
CC: <bharathsm@...rosoft.com>, <linux-cifs@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>, <pc@...guebit.org>,
	<ronniesahlberg@...il.com>, <samba-technical@...ts.samba.org>,
	<sfrench@...ba.org>, <sprasad@...rosoft.com>, <tom@...pey.com>,
	<wangfushuai@...du.com>
Subject: Re: [PATCH] cifs: Fix copy_to_iter return value check

>> The return value of copy_to_iter() function will never be negative,
>> it is the number of bytes copied, or zero if nothing was copied.
> …
> 
> Why do you propose to preserve the comparison operator part “<” then?
> Would the condition check “!length” be nicer at this place?

Yes, you are right. I will send a v2 shortly.

Regards,
Wang.