linux-kernel - Re: [PATCH] cifs: Fix copy_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <912d867a-f08f-40d3-bbd3-9ada24f468fd@web.de>
Date: Sun, 5 Oct 2025 12:45:47 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: Fushuai Wang <wangfushuai@...du.com>, linux-cifs@...r.kernel.org,
 samba-technical@...ts.samba.org, Bharath SM <bharathsm@...rosoft.com>,
 Paulo Alcantara <pc@...guebit.org>,
 Ronnie Sahlberg <ronniesahlberg@...il.com>,
 Shyam Prasad N <sprasad@...rosoft.com>, Steve French <sfrench@...ba.org>,
 Tom Talpey <tom@...pey.com>
Cc: LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] cifs: Fix copy_to_iter return value check

> The return value of copy_to_iter() function will never be negative,
> it is the number of bytes copied, or zero if nothing was copied.
…

Why do you propose to preserve the comparison operator part “<” then?
Would the condition check “!length” be nicer at this place?

Regards,
Markus