linux-kernel - Re: [PATCH 2/4] staging: rtl8723bs: split long comments in rtw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aONwAXk2EcV9Bgrv@stanley.mountain>
Date: Mon, 6 Oct 2025 10:30:09 +0300
From: Dan Carpenter <dan.carpenter@...aro.org>
To: Rohan Tripathi <trohan2000@...il.com>
Cc: gregkh@...uxfoundation.org, linux-staging@...ts.linux.dev,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/4] staging: rtl8723bs: split long comments in rtw_ap.c

On Sun, Oct 05, 2025 at 11:59:18AM -0400, Rohan Tripathi wrote:
> This patch splits overly long comments that exceeded 100 characters
> into multiple shorter lines, following kernel coding style guidelines.
> 
> This is a coding style cleanup only. No functional changes.
> 
> Signed-off-by: Rohan Tripathi <trohan2000@...il.com>
> ---
>  drivers/staging/rtl8723bs/core/rtw_ap.c | 17 +++++++++++++----
>  1 file changed, 13 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/staging/rtl8723bs/core/rtw_ap.c b/drivers/staging/rtl8723bs/core/rtw_ap.c
> index 93ab0015ca89..2c906c1137bf 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_ap.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_ap.c
> @@ -391,7 +391,9 @@ void update_bmc_sta(struct adapter *padapter)
>  
>  		memset((void *)&psta->sta_stats, 0, sizeof(struct stainfo_stats));
>  
> -		/* psta->dot118021XPrivacy = _NO_PRIVACY_;//!!! remove it, because it has been set before this. */
> +		/* psta->dot118021XPrivacy = _NO_PRIVACY_;
> +		 * remove it, because it has been set before this.
> +		 */
>  
>  		/* prepare for add_RATid */
>  		supportRateNum = rtw_get_rateset_len((u8 *)&pcur_network->supported_rates);
> @@ -655,7 +657,10 @@ void start_bss_network(struct adapter *padapter)
>  	cur_ch_offset = HAL_PRIME_CHNL_OFFSET_DONT_CARE;
>  
>  	/* check if there is wps ie, */
> -	/* if there is wpsie in beacon, the hostapd will update beacon twice when stating hostapd, */
> +	/* if there is wpsie in beacon,
> +	 *the hostapd will update beacon
> +	 *twice when stating hostapd,

Missing space after the asterisk.

regards,
dan carpenter