linux-kernel - Re: [PATCH 3/4] staging: rtl8723bs: remove unnecessary blank lines in rtw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aONwHi09P9VDTd3G@stanley.mountain>
Date: Mon, 6 Oct 2025 10:30:38 +0300
From: Dan Carpenter <dan.carpenter@...aro.org>
To: Rohan Tripathi <trohan2000@...il.com>
Cc: gregkh@...uxfoundation.org, linux-staging@...ts.linux.dev,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/4] staging: rtl8723bs: remove unnecessary blank lines
 in rtw_ap.c

On Sun, Oct 05, 2025 at 11:59:19AM -0400, Rohan Tripathi wrote:
> This patch removes superfluous blank lines and adds missing ones where
> appropriate to improve readability and match kernel coding style.
> 
> This is a coding style cleanup only. No functional changes.
> 
> Signed-off-by: Rohan Tripathi <trohan2000@...il.com>
> ---
>  drivers/staging/rtl8723bs/core/rtw_ap.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/rtl8723bs/core/rtw_ap.c b/drivers/staging/rtl8723bs/core/rtw_ap.c
> index 2c906c1137bf..dddb02c0f683 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_ap.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_ap.c
> @@ -438,7 +438,6 @@ void update_bmc_sta(struct adapter *padapter)
>  		spin_lock_bh(&psta->lock);
>  		psta->state = _FW_LINKED;
>  		spin_unlock_bh(&psta->lock);
> -
>  	}
>  }
>  
> @@ -1240,7 +1239,6 @@ void rtw_acl_remove_sta(struct adapter *padapter, u8 *addr)
>  	}
>  
>  	spin_unlock_bh(&pacl_node_q->lock);
> -
>  }
>  
>  u8 rtw_ap_set_pairwise_key(struct adapter *padapter, struct sta_info *psta)
> @@ -1974,6 +1972,7 @@ void ap_sta_info_defer_update(struct adapter *padapter, struct sta_info *psta)
>  		add_RATid(padapter, psta, 0);/* DM_RATR_STA_INIT */
>  	}
>  }
> +

This is adding a blank line, not removing.

regards,
dan carpenter

>  /* restore hw setting from sw data structures */
>  void rtw_ap_restore_network(struct adapter *padapter)
>  {
> -- 
> 2.50.1
>