linux-kernel - Re: [PATCH 1/2] dt-bindings: iio: max30100: Add pulse-width property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a72b4f39-6ebf-4598-b0fa-ae5b9754de58@kernel.org>
Date: Mon, 6 Oct 2025 23:40:26 +0900
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Shrikant Raskar <raskar.shree97@...il.com>, jic23@...nel.org,
 robh@...nel.org, krzk+dt@...nel.org, conor+dt@...nel.org
Cc: dlechner@...libre.com, nuno.sa@...log.com, andy@...nel.org,
 matt@...ostay.sg, skhan@...uxfoundation.org, david.hunter.linux@...il.com,
 linux-iio@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-kernel-mentees@...ts.linux.dev
Subject: Re: [PATCH 1/2] dt-bindings: iio: max30100: Add pulse-width property

On 04/10/2025 10:56, Shrikant Raskar wrote:
> The MAX30100 sensor supports multiple LED pulse widths (200us, 400us,
> 800us, 1600us). These settings affect measurement resolution and power
> consumption. Until now, the driver always defaulted to 1600us.
> 
> Introduce a new device tree property `maxim,pulse-width` that allows
> users to select the desired pulse width in microseconds from device
> tree.
> 
> Valid values are: 200, 400, 800, 1600.

Don't describe the contents of patch. We see the contents from the diff.
Above two paragraphs are completely redundant, drop.

> 
> This prepares for driver changes that read this property and configure
> the SPO2 register accordingly.

Drop, redundant. Not really relevant.

> 
> Signed-off-by: Shrikant Raskar <raskar.shree97@...il.com>
> ---
>  .../devicetree/bindings/iio/health/maxim,max30100.yaml      | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/iio/health/maxim,max30100.yaml b/Documentation/devicetree/bindings/iio/health/maxim,max30100.yaml
> index 967778fb0ce8..55aaf2ff919b 100644
> --- a/Documentation/devicetree/bindings/iio/health/maxim,max30100.yaml
> +++ b/Documentation/devicetree/bindings/iio/health/maxim,max30100.yaml
> @@ -27,6 +27,11 @@ properties:
>        LED current whilst the engine is running. First indexed value is
>        the configuration for the RED LED, and second value is for the IR LED.
>  
> +  maxim,pulse-width:

You miss unit suffix and testing, most likely.

> +    maxItems: 1
> +    description: Pulse width in microseconds
> +    enum: [200, 400, 800, 1600]x


Best regards,
Krzysztof