linux-kernel - Re: [PATCH 2/2] iio: health: max30100: Add pulse-width configuration via DT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <202510092124.rc01eF4I-lkp@intel.com>
Date: Thu, 9 Oct 2025 21:28:19 +0800
From: kernel test robot <lkp@...el.com>
To: Shrikant Raskar <raskar.shree97@...il.com>, jic23@...nel.org,
	robh@...nel.org, krzk+dt@...nel.org, conor+dt@...nel.org
Cc: oe-kbuild-all@...ts.linux.dev, dlechner@...libre.com,
	nuno.sa@...log.com, andy@...nel.org, matt@...ostay.sg,
	skhan@...uxfoundation.org, david.hunter.linux@...il.com,
	linux-iio@...r.kernel.org, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-kernel-mentees@...ts.linux.dev,
	Shrikant Raskar <raskar.shree97@...il.com>
Subject: Re: [PATCH 2/2] iio: health: max30100: Add pulse-width configuration
 via DT

Hi Shrikant,

kernel test robot noticed the following build warnings:

[auto build test WARNING on jic23-iio/togreg]
[also build test WARNING on robh/for-next linus/master v6.17 next-20251008]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Shrikant-Raskar/dt-bindings-iio-max30100-Add-pulse-width-property/20251004-095849
base:   https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git togreg
patch link:    https://lore.kernel.org/r/20251004015623.7019-3-raskar.shree97%40gmail.com
patch subject: [PATCH 2/2] iio: health: max30100: Add pulse-width configuration via DT
config: arm-randconfig-r073-20251004 (https://download.01.org/0day-ci/archive/20251009/202510092124.rc01eF4I-lkp@intel.com/config)
compiler: arm-linux-gnueabi-gcc (GCC) 8.5.0

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202510092124.rc01eF4I-lkp@intel.com/

smatch warnings:
drivers/iio/health/max30100.c:346 max30100_chip_init() warn: unsigned 'pulse_width' is never less than zero.
drivers/iio/health/max30100.c:346 max30100_chip_init() warn: error code type promoted to positive: 'pulse_width'

vim +/pulse_width +346 drivers/iio/health/max30100.c

   326	
   327	static int max30100_chip_init(struct max30100_data *data)
   328	{
   329		int ret;
   330		unsigned int pulse_us;
   331		unsigned int pulse_width;
   332		struct device *dev = &data->client->dev;
   333	
   334		/* setup LED current settings */
   335		ret = max30100_led_init(data);
   336		if (ret)
   337			return ret;
   338	
   339		/* Get pulse width from DT, default = 1600us */
   340		ret = device_property_read_u32(dev, "maxim,pulse-width", &pulse_us);
   341		if (ret) {
   342			dev_warn(dev, "no pulse-width defined, defaulting to 1600us\n");
   343			pulse_width = MAX30100_REG_SPO2_CONFIG_1600US;
   344		} else {
   345			pulse_width = max30100_get_pulse_width(pulse_us);
 > 346			if (pulse_width < 0) {
   347				dev_err(dev, "invalid pulse-width %u\n", pulse_us);
   348				return pulse_width;
   349			}
   350		}
   351	
   352		/* enable hi-res SPO2 readings at 100Hz */
   353		ret = regmap_write(data->regmap, MAX30100_REG_SPO2_CONFIG,
   354					 MAX30100_REG_SPO2_CONFIG_HI_RES_EN |
   355					 MAX30100_REG_SPO2_CONFIG_100HZ |
   356					 pulse_width);
   357		if (ret)
   358			return ret;
   359	
   360		/* enable SPO2 mode */
   361		ret = regmap_update_bits(data->regmap, MAX30100_REG_MODE_CONFIG,
   362					 MAX30100_REG_MODE_CONFIG_MODE_MASK,
   363					 MAX30100_REG_MODE_CONFIG_MODE_HR_EN |
   364					 MAX30100_REG_MODE_CONFIG_MODE_SPO2_EN);
   365		if (ret)
   366			return ret;
   367	
   368		/* enable FIFO interrupt */
   369		return regmap_update_bits(data->regmap, MAX30100_REG_INT_ENABLE,
   370					 MAX30100_REG_INT_ENABLE_MASK,
   371					 MAX30100_REG_INT_ENABLE_FIFO_EN
   372					 << MAX30100_REG_INT_ENABLE_MASK_SHIFT);
   373	}
   374	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki