linux-kernel - Re: [PATCH v12-1 3/3] iio: ABI: Add voltage mean raw attribute

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5e043789-75b4-4586-b9ea-a6cda8532431@baylibre.com>
Date: Mon, 6 Oct 2025 11:36:23 -0500
From: David Lechner <dlechner@...libre.com>
To: Marilene Andrade Garcia <marilene.agarcia@...il.com>,
 linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org,
 devicetree@...r.kernel.org
Cc: Kim Seer Paller <kimseer.paller@...log.com>,
 Lars-Peter Clausen <lars@...afoo.de>,
 Michael Hennerich <Michael.Hennerich@...log.com>,
 Jonathan Cameron <jic23@...nel.org>, Nuno Sá
 <nuno.sa@...log.com>, Andy Shevchenko <andy@...nel.org>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>,
 Marcelo Schmitt <marcelo.schmitt1@...il.com>,
 Marcelo Schmitt <Marcelo.Schmitt@...log.com>,
 Ceclan Dumitru <dumitru.ceclan@...log.com>,
 Jonathan Santos <Jonathan.Santos@...log.com>,
 Dragos Bogdan <dragos.bogdan@...log.com>
Subject: Re: [PATCH v12-1 3/3] iio: ABI: Add voltage mean raw attribute

On 9/29/25 12:59 AM, Marilene Andrade Garcia wrote:
> Add the missing in_voltageY_mean_raw attribute for the average of voltage
> measurements.
> 
> Signed-off-by: Marilene Andrade Garcia <marilene.agarcia@...il.com>
> ---
> 
> When I use _mean_raw (IIO_CHAN_INFO_AVERAGE_RAW), I get a file called 
> in_voltageY_mean_raw, so I added it to the documentation. 
> Thanks.
> 
>  Documentation/ABI/testing/sysfs-bus-iio | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/ABI/testing/sysfs-bus-iio b/Documentation/ABI/testing/sysfs-bus-iio
> index 352ab7b8476c..3efaf91248ca 100644
> --- a/Documentation/ABI/testing/sysfs-bus-iio
> +++ b/Documentation/ABI/testing/sysfs-bus-iio
> @@ -422,6 +422,7 @@ Description:
>  		Scaled humidity measurement in milli percent.
>  
>  What:		/sys/bus/iio/devices/iio:deviceX/in_Y_mean_raw
> +What:		/sys/bus/iio/devices/iio:deviceX/in_voltageY_mean_raw
>  KernelVersion:	3.5
>  Contact:	linux-iio@...r.kernel.org
>  Description:

I did a search of the IIO subsystem for IIO_CHAN_INFO_AVERAGE_RAW and saw
that it is also being used for temperature channels (both indexed and not)
and indexed current and capacitance channels and also one indexed light
channel.

So we could either delete the line with in_Y_mean_raw and add all of the
ones that are actually being used or we could leave it as-is since I think
in_Y_mean_raw is meant to be in_<any type>Y_mean_raw. This is the only
attribute in the docs like that though, so making it more explicit like
everything else seems like an improvement to me.

If we do change it, the change stands on it's own, so you can just start
a new series for it rather than calling it v13-1. Just include a link to
the previous discussion after the --- so we don't forget about it. And you
can drop some of the folks from the Cc:, like the DT maintainers that don't
need to be bothered with this.