linux-kernel - Re: [PATCH v5 6/9] rust: bitfield: Add KUNIT tests for bitfield

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <cea9b90b-649b-4e84-92d1-188565450a98@nvidia.com>
Date: Mon, 6 Oct 2025 15:50:07 -0400
From: Joel Fernandes <joelagnelf@...dia.com>
To: Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
Cc: Alexandre Courbot <acourbot@...dia.com>,
 "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
 "rust-for-linux@...r.kernel.org" <rust-for-linux@...r.kernel.org>,
 "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
 "dakr@...nel.org" <dakr@...nel.org>, Alistair Popple <apopple@...dia.com>,
 Miguel Ojeda <ojeda@...nel.org>, Alex Gaynor <alex.gaynor@...il.com>,
 Boqun Feng <boqun.feng@...il.com>, Gary Guo <gary@...yguo.net>,
 "bjorn3_gh@...tonmail.com" <bjorn3_gh@...tonmail.com>,
 Benno Lossin <lossin@...nel.org>, Andreas Hindborg <a.hindborg@...nel.org>,
 Alice Ryhl <aliceryhl@...gle.com>, Trevor Gross <tmgross@...ch.edu>,
 David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>,
 Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
 Maxime Ripard <mripard@...nel.org>, Thomas Zimmermann <tzimmermann@...e.de>,
 John Hubbard <jhubbard@...dia.com>, Timur Tabi <ttabi@...dia.com>,
 "joel@...lfernandes.org" <joel@...lfernandes.org>,
 Elle Rhumsaa <elle@...thered-steel.dev>, Yury Norov <yury.norov@...il.com>,
 Daniel Almeida <daniel.almeida@...labora.com>,
 Andrea Righi <arighi@...dia.com>,
 "nouveau@...ts.freedesktop.org" <nouveau@...ts.freedesktop.org>
Subject: Re: [PATCH v5 6/9] rust: bitfield: Add KUNIT tests for bitfield



On 10/6/2025 12:40 PM, Miguel Ojeda wrote:
> On Sat, Oct 4, 2025 at 6:14 PM Joel Fernandes <joelagnelf@...dia.com> wrote:
>>
>> Well, it can be efficient. It really depends. I have been contributing upstream for about 15 years if you see the git log, often when someone chats privately with me like you did and they told me they are ok with a patch, I save them the trouble and add their review tag especially after they already added their tag to all my other patches. Surprisingly though this is probably the first time anyone has been pissed off about it.  Anyway I will not add your tag henceforth unless you publicly reply (or you let me know otherwise by chat).
> 
> If they just say they are OK with a patch, that would just mean an
> Acked-by, not a Reviewed-by.
>> In any case, the documentation states those tags cannot be added
> without permission -- if someone gives you a tag privately, it is best
> that you tell them to please send it in the mailing list instead. That
> way there is no confusion and others (including tooling, e.g.
> patchwork and b4) can see it.
Sure, certainly it goes against docs/guidelines to add a tag *without
permission*. I don't think anyone disputed that? I don't think I was advocating
adding RB tags randomly without consent at all - please don't get me wrong. :-)

And no doubts that publicly replying with RB tags is the best way.

cheers,

 - Joel