linux-kernel - Re: [PATCH v3] drm/komeda: Convert logging in komeda_crtc.c to drm_* with drm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f774da25-ab98-4731-b78d-394d8e3a4c3a@linuxfoundation.org>
Date: Tue, 7 Oct 2025 17:16:27 -0600
From: Shuah Khan <skhan@...uxfoundation.org>
To: Rahul Kumar <rk0006818@...il.com>, liviu.dudau@....com,
 maarten.lankhorst@...ux.intel.com, mripard@...nel.org, tzimmermann@...e.de,
 airlied@...il.com, simona@...ll.ch
Cc: dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
 linux-kernel-mentees@...ts.linux.dev, Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [PATCH v3] drm/komeda: Convert logging in komeda_crtc.c to drm_*
 with drm_device parameter

On 10/3/25 11:51, Rahul Kumar wrote:
> Hi Liviu,
> 
> Just following up to ask if anything more is needed from my side for
> this patch, or if you plan to pick it up in this merge window.
> 
> Thanks,
> Rahul
> 

Rahul, no top posting. Please give people time to respond before
sending a second email asking for feedback. I see two messages
back to back from you - perhaps an error during send.

> On Fri, Sep 26, 2025 at 3:00 PM Rahul Kumar <rk0006818@...il.com> wrote:
>>
>> Replace all dev_err(), dev_warn(), dev_info() and DRM_ERROR/WARN/INFO()
>> calls in drivers/gpu/drm/arm/display/komeda/komeda_crtc.c with the
>> corresponding drm_err(), drm_warn(), and drm_info() helpers.
>>
>> The new drm_*() logging functions take a struct drm_device * as the
>> first argument. This allows the DRM core to prefix log messages with
>> the specific DRM device name and instance, which is essential for
>> distinguishing logs when multiple GPUs or display controllers are present.
>>
>> This change aligns komeda with the DRM TODO item: "Convert logging to
>> drm_* functions with drm_device parameter".
>>
>> Signed-off-by: Rahul Kumar <rk0006818@...il.com>
>> Reviewed-by: Liviu Dudau <liviu.dudau@....com>
>> ---
>> Changes since v2:
>> - Added Reviewed-by tag from Liviu Dudau
>>

thanks,
-- Shuah