linux-kernel - Re: [PATCH v10 01/15] x86/cpu: Enumerate the LASS feature bits

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7a5a28a3-baf4-4915-8585-eae8cd323895@zytor.com>
Date: Wed, 8 Oct 2025 07:16:28 +0800
From: Xin Li <xin@...or.com>
To: Sohil Mehta <sohil.mehta@...el.com>,
        "Edgecombe, Rick P" <rick.p.edgecombe@...el.com>,
        "tglx@...utronix.de" <tglx@...utronix.de>,
        "mingo@...hat.com" <mingo@...hat.com>, "bp@...en8.de" <bp@...en8.de>,
        "x86@...nel.org" <x86@...nel.org>,
        "dave.hansen@...ux.intel.com" <dave.hansen@...ux.intel.com>
Cc: "corbet@....net" <corbet@....net>, "ardb@...nel.org" <ardb@...nel.org>,
        "david.laight.linux@...il.com" <david.laight.linux@...il.com>,
        "luto@...nel.org" <luto@...nel.org>,
        "jpoimboe@...nel.org" <jpoimboe@...nel.org>,
        "andrew.cooper3@...rix.com" <andrew.cooper3@...rix.com>,
        "Luck, Tony" <tony.luck@...el.com>,
        "alexander.shishkin@...ux.intel.com" <alexander.shishkin@...ux.intel.com>,
        "kas@...nel.org" <kas@...nel.org>,
        "seanjc@...gle.com" <seanjc@...gle.com>,
        "rdunlap@...radead.org" <rdunlap@...radead.org>,
        "dwmw@...zon.co.uk" <dwmw@...zon.co.uk>,
        "vegard.nossum@...cle.com" <vegard.nossum@...cle.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>,
        "kees@...nel.org" <kees@...nel.org>, "hpa@...or.com" <hpa@...or.com>,
        "peterz@...radead.org" <peterz@...radead.org>,
        "linux-efi@...r.kernel.org" <linux-efi@...r.kernel.org>,
        "geert@...ux-m68k.org" <geert@...ux-m68k.org>
Subject: Re: [PATCH v10 01/15] x86/cpu: Enumerate the LASS feature bits

On 10/8/2025 4:49 AM, Sohil Mehta wrote:
>>>   
>>> +config X86_DISABLED_FEATURE_LASS
>>> +	def_bool y
>>> +	depends on X86_32
>>> +
>> All the other ones in the file are !X86_64. Why do this one X86_32?
>>
> The double negation (DISABLED and !X86_64) was harder to follow when
> this was initially posted.
> 
> https://lore.kernel.org/lkml/73796800-819b-4433-b0ef-db852336d7a4@zytor.com/
> https://lore.kernel.org/lkml/756e93a2-7e42-4323-ae21- 
> a5437e71148e@...radead.org/
> 
> I don't have a strong preference. I guess the inconsistency makes it
> confusing as well. Will change it back to !X86_64 unless Xin objects.

I prefer to use X86_32, which is more direct.

Now the only disabled feature when !X86_64 is X86_DISABLED_FEATURE_PCID.
And I would expect the disabled features due to lack of 32-bit enabling 
will keep growing until we remove 32-bit kernel code.  I was also thinking
to move all such disabled features to a dedicated file when the total
reaches 3.  But hopefully removing 32-bit will happen first.