linux-kernel - Re: [PATCH RFC] gen_init_cpio: Do fsync() only on regular files

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aOStTfvOR-C7l1se@infradead.org>
Date: Mon, 6 Oct 2025 23:03:57 -0700
From: Christoph Hellwig <hch@...radead.org>
To: David Disseldorp <ddiss@...e.de>
Cc: Christoph Hellwig <hch@...radead.org>, dima@...sta.com,
	Nathan Chancellor <nathan@...nel.org>,
	Nicolas Schier <nicolas.schier@...ux.dev>,
	linux-kbuild@...r.kernel.org, linux-kernel@...r.kernel.org,
	Nicolas Schier <nsc@...nel.org>
Subject: Re: [PATCH RFC] gen_init_cpio: Do fsync() only on regular files

On Tue, Oct 07, 2025 at 04:57:32PM +1100, David Disseldorp wrote:
> I should have explained why in the commit, sorry. The intention was to
> catch any FS I/O errors during output archive writeback. fsync() is
> called only once as the final I/O.

I don't parse this.  What does 'as the final I/O' mean?  If you want
to catch writeback errors, a single syncfs should be enough.