[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <03a4cb5e-85da-44f3-8fcc-67e23920cd5a@gmail.com>
Date: Mon, 6 Oct 2025 21:03:03 -0400
From: David Hunter <david.hunter.linux@...il.com>
To: vivek yadav <vivekyadav1207731111@...il.com>,
Johan Hovold <johan@...nel.org>
Cc: gregkh@...uxfoundation.org, linux-usb@...r.kernel.org,
linux-kernel@...r.kernel.org, skhan@...uxfoundation.org,
linux-kernel-mentees@...ts.linux.dev
Subject: Re: [PATCH] usb: serial: fix: space prohibited before comma separator
On 10/6/25 13:54, vivek yadav wrote:
> Hi Johan,
> Thanks for giving time for the review of my patch.
> I understand your point and will avoid such kind of practice.
>
>
> ~~Vivek
>
> On Mon, Oct 6, 2025 at 5:42 PM Johan Hovold <johan@...nel.org> wrote:
>>
>> On Sat, Oct 04, 2025 at 12:26:18PM +0530, vivekyadav1207731111@...il.com wrote:
>>> From: Vivek Yadav <vivekyadav1207731111@...il.com>
>>>
>>> Run `checkpatch.pl` script on path `drivers/usb/serial/*`.
>>
>> Yeah, don't do that, that is, don't run checkpatch on code that's
>> already in the tree. Use it on your on patches before submitting them to
>> catch potential issues, but always use your own judgement when
>> considering its output.
>>
>> If you just want to practise sending patches, changes like these are
>> accepted for drivers/staging for that purpose.
>>
>> Johan
Please don't top-post. please look at the following wikipedia page to
see what top-post means:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
Powered by blists - more mailing lists