linux-kernel - Re: [PATCH] sound/soc/codecs/wm8978: add missing BCLK divider setup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAN7C2SAQ0rCZ=qPfh_MfQg_z0u7sWyFpFHUa2-Wwh_iTnNJGLQ@mail.gmail.com>
Date: Tue, 7 Oct 2025 20:37:55 +0800
From: Sune Brian <briansune@...il.com>
To: Mark Brown <broonie@...nel.org>
Cc: Sune Brian <briansune@...il.com>, Liam Girdwood <lgirdwood@...il.com>, 
	Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>, linux-sound@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] sound/soc/codecs/wm8978: add missing BCLK divider setup

Mark Brown <broonie@...nel.org> 於 2025年10月7日 週二 下午8:30寫道：
>
> On Tue, Oct 07, 2025 at 01:26:52PM +0100, Charles Keepax wrote:
>
> > I don't see any current users for the manual divider configuration
> > at least in mainline, so we could probably just drop the manual
> > stuff. I don't think I have a strong opinion between that
> > and blocking the automatic configuration if it was previously
> > set manually, but we should do one of them to keep things clear.
>
> Yes, definitely.

if you read that code more clearly. It is a case that is select between
WM8978_OPCLKRATE and WM8978_BCLKDIV.
With the latest test on the dts file.
When running such codec on master mode the bclk had never set to correct
bclk rate. As such even you see that codes exist. It never run as expected.
I am not sure any adjust is required on dts but with proper lrclk and
mclk output.
The bclk is wrong on that version.

This is why I propose the patch of the bclk.