[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <9628cba6-f793-4301-8620-8de46e0c5c97@suse.com>
Date: Tue, 7 Oct 2025 15:50:02 +0300
From: Nikolay Borisov <nik.borisov@...e.com>
To: Petr Tesarik <ptesarik@...e.com>, "H. Peter Anvin" <hpa@...or.com>,
Thomas Gleixner <tglx@...utronix.de>, Ingo Molnar <mingo@...hat.com>,
Borislav Petkov <bp@...en8.de>, Dave Hansen <dave.hansen@...ux.intel.com>
Cc: Pawan Gupta <pawan.kumar.gupta@...ux.intel.com>,
"maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)" <x86@...nel.org>,
"open list:X86 ARCHITECTURE (32-BIT AND 64-BIT)"
<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 2/2] x86/tsx: Get the tsx= command line parameter with
early_param()
On 26.09.25 г. 21:01 ч., Petr Tesarik wrote:
> Use early_param() to get the value of the tsx= command line parameter.
> Although cmdline_find_option() works fine, the option is later reported
> as unknown and passed to user space. The latter is not a real issue, but
> the former is confusing and makes people wonder if the tsx= parameter had
> any effect and double-check for typos unnecessarily.
>
> The behavior changes slightly if "tsx" is given without any argument (which
> is invalid syntax). Prior to this patch, the kernel logged an error message
> and disabled TSX. With this patch, the parameter is ignored. The new
> behavior is consistent with other parameters, e.g. "tsx_async_abort".
>
> Signed-off-by: Petr Tesarik <ptesarik@...e.com>
LGTM, also could you include some rationale why early_param vs __setup
for example, or arch_param_cb (which by the way has yet to find its
first user).
Reviewed-by: Nikolay Borisov <nik.borisov@...e.com>
Powered by blists - more mailing lists