linux-kernel - Re: [PATCH 1/2] dt-bindings: sound: qcom,sm8250: add QRB2210 and RB1 soundcards

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <67e313d3-1f91-4205-8aec-fbbfa41004f2@kernel.org>
Date: Tue, 7 Oct 2025 10:45:07 +0900
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Alexey Klimov <alexey.klimov@...aro.org>,
 Srinivas Kandagatla <srini@...nel.org>, Liam Girdwood <lgirdwood@...il.com>,
 Mark Brown <broonie@...nel.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>
Cc: Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>,
 Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com>,
 linux-sound@...r.kernel.org, linux-arm-msm@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: sound: qcom,sm8250: add QRB2210 and RB1
 soundcards

On 07/10/2025 10:26, Alexey Klimov wrote:
> Add soundcard compatible for QRB2210 (QCM2290) platforms.
> While at this, also add QRB2210 RB1 entry which is set to be
> compatible with QRB2210 soundcard.


You explained here what you did, but you should explain why. I don't
quite get why SoC sound card and RB1 sound card are both needed. I would
just go with one.

Please use subject prefixes matching the subsystem. For bindings, the
preferred subjects are explained here:
https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html#i-for-patch-submitters

> 


Best regards,
Krzysztof